[vim/vim] fix: redraw status lines after closing or hiding a popup window (PR #19830)

8 views
Skip to first unread message

mattn

unread,
Mar 26, 2026, 3:07:08 AM (yesterday) Mar 26
to vim/vim, Subscribed

When a popup window overlapping a status line is closed or hidden, the status line was not redrawn, leaving ghost artifacts from the popup.

popup_free() and popup_hide() call redraw_all_later(UPD_NOT_VALID) which marks window contents for redraw but does not set w_redr_status. The diff-based path in may_update_popup_mask() that normally sets w_redr_status is skipped when redrawing_all_win is TRUE. Add status_redraw_all() calls to ensure status lines are properly redrawn.


You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/19830

Commit Summary

  • 54be1fd fix: redraw status lines after closing or hiding a popup window

File Changes

(1 file)

Patch Links:


Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19830@github.com>

mattn

unread,
Mar 26, 2026, 3:11:12 AM (yesterday) Mar 26
to vim/vim, Push

@mattn pushed 1 commit.

  • 0496128 test: add screendump test for popup close status line redraw


View it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19830/before/54be1fd6980cab2c4c446569d720bb318bf8cfaf/after/0496128671597d5d43a0e85d172bdaa9b3c2109b@github.com>

Christian Brabandt

unread,
Mar 26, 2026, 5:14:58 PM (13 hours ago) Mar 26
to vim/vim, Subscribed
chrisbra left a comment (vim/vim#19830)

thanks


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19830/c4138253958@github.com>

Christian Brabandt

unread,
Mar 26, 2026, 5:28:11 PM (13 hours ago) Mar 26
to vim/vim, Subscribed

Closed #19830 via 575961c.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19830/issue_event/23950343298@github.com>

Reply all
Reply to author
Forward
0 new messages