[vim/vim] Add tests for helptags command and substitute in Ex mode (#5567)

13 views
Skip to first unread message

Yegappan Lakshmanan

unread,
Feb 2, 2020, 2:22:57 PM2/2/20
to vim/vim, Subscribed

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/5567

Commit Summary

  • Add tests for helptags command and substitute in Ex mode

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Yegappan Lakshmanan

unread,
Feb 2, 2020, 2:47:38 PM2/2/20
to vim/vim, Push

@yegappan pushed 1 commit.

  • fa4f48b Run the permission test only on Unix-like systems


You are receiving this because you are subscribed to this thread.

View it on GitHub or unsubscribe.

Bram Moolenaar

unread,
Feb 2, 2020, 4:28:26 PM2/2/20
to vim/vim, Subscribed

Appears to fail on FreeBSD:
Failures:
From test_help.vim:
Found errors in Test_helptag_cmd():
function RunTheTest[40]..Test_helptag_cmd line 17: command did not fail: helptags Xdir
function RunTheTest[40]..Test_helptag_cmd line 22: command did not fail: helptags Xdir

Yegappan Lakshmanan

unread,
Feb 2, 2020, 4:43:09 PM2/2/20
to vim/vim, Push

@yegappan pushed 1 commit.

  • df2f664 Display file permissions to debug why the test fails only on FreeBSD


You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,
Feb 2, 2020, 4:46:20 PM2/2/20
to vim_dev, reply+ACY5DGB26JYSZ5KRZT...@reply.github.com, vim/vim, Subscribed
Hi Bram,

On Sun, Feb 2, 2020 at 1:28 PM Bram Moolenaar <vim-dev...@256bit.org> wrote:

Appears to fail on FreeBSD:
Failures:
From test_help.vim:
Found errors in Test_helptag_cmd():
function RunTheTest[40]..Test_helptag_cmd line 17: command did not fail: helptags Xdir
function RunTheTest[40]..Test_helptag_cmd line 22: command did not fail: helptags Xdir



I am not sure why the test fails only on FreeBSD. I am not able to reproduce this failure
on my local FreeBSD setup.

- Yegappan
 

vim-dev ML

unread,
Feb 2, 2020, 4:46:21 PM2/2/20
to vim/vim, vim-dev ML, Your activity

Yegappan Lakshmanan

unread,
Feb 2, 2020, 4:59:49 PM2/2/20
to vim/vim, vim-dev ML, Push

@yegappan pushed 1 commit.

  • 29f979a Skip the help file and tags file permission test on FreeBSD


You are receiving this because you are subscribed to this thread.

Codecov

unread,
Feb 2, 2020, 5:23:08 PM2/2/20
to vim/vim, vim-dev ML, Comment

Codecov Report

Merging #5567 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@

##           master    #5567      +/-   ##

==========================================

- Coverage   82.93%   82.81%   -0.13%     

==========================================

  Files         137      137              

  Lines      151835   149206    -2629     

==========================================

- Hits       125927   123562    -2365     

+ Misses      25908    25644     -264
Impacted Files Coverage Δ
src/libvterm/src/unicode.c 82.6% <0%> (-6.53%) ⬇️
src/search.c 81.29% <0%> (-0.83%) ⬇️
src/gui.c 62.91% <0%> (-0.73%) ⬇️
src/mouse.c 76.07% <0%> (-0.72%) ⬇️
src/screen.c 83.92% <0%> (-0.71%) ⬇️
src/move.c 86.9% <0%> (-0.68%) ⬇️
src/profiler.c 94.03% <0%> (-0.65%) ⬇️
src/ops.c 89.05% <0%> (-0.62%) ⬇️
src/scriptfile.c 89.65% <0%> (-0.56%) ⬇️
src/debugger.c 93.58% <0%> (-0.53%) ⬇️
... and 111 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f18b6d...29f979a. Read the comment docs.


You are receiving this because you commented.

Yegappan Lakshmanan

unread,
Feb 3, 2020, 3:11:00 AM2/3/20
to vim/vim, vim-dev ML, Push

@yegappan pushed 1 commit.

  • b65d0d8 Add tests for confirm dialog and ex command errors


You are receiving this because you are subscribed to this thread.

Bram Moolenaar

unread,
Feb 3, 2020, 3:40:17 PM2/3/20
to vim/vim, vim-dev ML, Comment

Closed #5567 via e20b9ec.


You are receiving this because you commented.

Reply all
Reply to author
Forward
0 new messages