[vim/vim] Fix popup right edge overflowing the screen (PR #20042)
mattn
popup_adjust_position() did not reserve room for the right border/padding/shadow, so a popup at maximum width drew its right side past the screen edge. Usually invisible due to terminal clipping, but visible with the tabpanel where it wrapped into the tabpanel area.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/20042
Commit Summary
- ad1ffa9 Fix popup right edge overflowing the screen
File Changes
(15 files)
- M src/popupwin.c (44)
- M src/testdir/dumps/Test_popupwin_20.dump (4)
- M src/testdir/dumps/Test_popupwin_21.dump (4)
- M src/testdir/dumps/Test_popupwin_drag_minwidth_1.dump (18)
- M src/testdir/dumps/Test_popupwin_drag_minwidth_2.dump (12)
- M src/testdir/dumps/Test_popupwin_drag_minwidth_3.dump (16)
- M src/testdir/dumps/Test_popupwin_mask_3.dump (8)
- M src/testdir/dumps/Test_popupwin_previewpopup_10.dump (12)
- M src/testdir/dumps/Test_popupwin_previewpopup_4.dump (12)
- M src/testdir/dumps/Test_popupwin_previewpopup_5.dump (12)
- M src/testdir/dumps/Test_popupwin_previewpopup_7.dump (12)
- M src/testdir/dumps/Test_popupwin_previewpopup_8.dump (12)
- M src/testdir/dumps/Test_popupwin_previewpopup_9.dump (12)
- M src/testdir/dumps/Test_popupwin_wrap_1.dump (12)
- M src/testdir/dumps/Test_popupwin_wrap_2.dump (12)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
mattn
mattn left a comment (vim/vim#20042)please wait merge
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
mattn
@mattn pushed 1 commit.
- f53b75e Fix popup right edge overflowing the screen
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
mattn
mattn left a comment (vim/vim#20042)Please wait merge
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
mattn
mattn left a comment (vim/vim#20042)Verified this pull-request fix the issue.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
mattn
mattn left a comment (vim/vim#20042)Still have another issue
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
mattn
@mattn pushed 1 commit.
- 7b38309 Stabilize popup width across scrolling
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.