[vim/vim] :wqall! doesn't close a terminal buffer like :qall! does (PR #19129)

zeertzjq

unread,

Jan 7, 2026, 10:09:09 PM (2 days ago) Jan 7

to vim/vim, Subscribed

Problem: :wqall! doesn't close a terminal buffer like :qall! does.
Solution: Check eap->forceit.

related: neovim/neovim#14061

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/19129

Commit Summary

4c17f0d :wqall! doesn't close a terminal buffer like :qall! does

File Changes

(2 files)

M src/ex_cmds.c (2)
M src/testdir/test_terminal.vim (24)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

zeertzjq

unread,

Jan 7, 2026, 10:13:57 PM (2 days ago) Jan 7

to vim/vim, Push

@zeertzjq pushed 1 commit.

cc8ceb8 :wqall! doesn't close a terminal buffer like :qall! does

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Jan 8, 2026, 5:01:41 AM (yesterday) Jan 8

to vim/vim, Subscribed

chrisbra left a comment (vim/vim#19129)

Unrelated to the actual change, but what is wrong with those sudden failures?

clang -c -I. -DPERL_DARWIN -DNO_THREAD_SAFE_QUERYLOCALE -DNO_POSIX_2008_LOCALE -DHAS_BROKEN_LANGINFO_CODESET -DNO_LOCALE_COLLATE -fno-strict-aliasing -fstack-protector-strong  -I/opt/homebrew/opt/perl/lib/perl5/5.42/darwin-thread-multi-2level/CORE  -Iproto -DHAVE_CONFIG_H   -DMACOS_X -DMACOS_X_DARWIN -I/opt/homebrew/Cellar/libsodium/1.0.20/include  -g -O2  -D_REENTRANT -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -Wall -Wextra -Wshadow -Wstrict-prototypes -Wmissing-prototypes -Werror -Wno-deprecated-declarations -Wno-error=missing-field-initializers   -DEXITFREE     -Wno-error=unused-function -Wno-shadow -Wno-error=compound-token-split-by-macro -Wno-compound-token-split-by-macro -o objects/if_perl.o auto/if_perl.c
clang -c -I. -I/opt/homebrew/opt/pyt...@3.14/Frameworks/Python.framework/Versions/3.14/include/python3.14 -fPIE -Iproto -DHAVE_CONFIG_H   -DMACOS_X -DMACOS_X_DARWIN -I/opt/homebrew/Cellar/libsodium/1.0.20/include  -g -O2  -D_REENTRANT -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -Wall -Wextra -Wshadow -Wstrict-prototypes -Wmissing-prototypes -Werror -Wno-deprecated-declarations -Wno-error=missing-field-initializers   -DEXITFREE      -o objects/if_python3.o if_python3.c
In file included from if_perl.xs:49:
/opt/homebrew/opt/perl/lib/perl5/5.42/darwin-thread-multi-2level/CORE/perl.h:5338:32: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
 5338 | typedef void (*shutdown_proc_t)();
      |                                ^
      |                                 void
1 error generated.
make[1]: *** [objects/if_perl.o] Error 1

That seems to happen inside the Perl header. Can we fix the CI?

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

zeertzjq

unread,

Jan 8, 2026, 5:45:02 AM (yesterday) Jan 8

to vim/vim, Subscribed

zeertzjq left a comment (vim/vim#19129)

#19132 seems to fix that

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Jan 8, 2026, 3:20:39 PM (yesterday) Jan 8

to vim/vim, Subscribed

chrisbra left a comment (vim/vim#19129)

thanks

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Jan 8, 2026, 3:26:05 PM (yesterday) Jan 8

to vim/vim, Subscribed

Closed #19129 via d8558fd.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Reply all

Reply to author

Forward