[vim/vim] Update the heredoc support for embedded scripting languages (#5916)

[Yegappan Lakshmanan]

The heredoc support for the embedded scripting languages like python is
missing some of the features of the :let here document. For example,
leading indentation for the lines is not supported. This patch updates
the script heredoc support to be same as the :let command.
One difference is the script heredoc accepts '.' as the marker if the
marker is not supplied.

---

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/5916

Commit Summary

• Update the heredoc support for python/lua/perl/ruby/tcl/mzsch scripts to be same as the :let command

File Changes

• M runtime/doc/if_lua.txt (7)
• M runtime/doc/if_mzsch.txt (9)
• M runtime/doc/if_perl.txt (2)
• M runtime/doc/if_pyth.txt (11)
• M runtime/doc/if_ruby.txt (8)
• M runtime/doc/if_tcl.txt (7)
• M src/evalvars.c (21)
• M src/ex_getln.c (35)
• M src/proto/evalvars.pro (2)

Patch Links:

• https://github.com/vim/vim/pull/5916.patch
• https://github.com/vim/vim/pull/5916.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

[Yegappan Lakshmanan]

@yegappan pushed 1 commit.

• 638f11e Fix build error

—
You are receiving this because you are subscribed to this thread.

View it on GitHub or unsubscribe.

[Yegappan Lakshmanan]

@yegappan pushed 1 commit.

• 438c567 Fix build errors

—
You are receiving this because you are subscribed to this thread.

[Bram Moolenaar]

Supporting "trim" for the interfaces is lacking tests.

[Yegappan Lakshmanan]

@yegappan pushed 1 commit.

• b8060a6 Update the tests for various embedded language scripts to use the new heredoc syntax

—
You are receiving this because you are subscribed to this thread.

[Yegappan Lakshmanan]

@yegappan pushed 1 commit.

• df5f6b8 Fix test failures

—
You are receiving this because you are subscribed to this thread.

[Codecov]

Codecov Report

Merging #5916 into master will increase coverage by 0.03%.
The diff coverage is 96.00%.

@@            Coverage Diff             @@

##           master    #5916      +/-   ##

==========================================

+ Coverage   86.24%   86.27%   +0.03%     

==========================================

  Files         136      140       +4     

  Lines      155482   155846     +364     

==========================================

+ Hits       134088   134451     +363     

- Misses      21394    21395       +1     

Impacted Files	Coverage Δ
src/ex_getln.c	91.43% <90.00%> (-0.08%)	⬇️
src/evalvars.c	94.95% <100.00%> (+<0.01%)	⬆️
src/userfunc.c	92.75% <100.00%> (+0.02%)	⬆️
src/vim9compile.c	94.86% <100.00%> (ø)
src/netbeans.c	27.20% <0.00%> (-0.23%)	⬇️
src/gui.c	63.85% <0.00%> (-0.16%)	⬇️
src/terminal.c	82.92% <0.00%> (-0.04%)	⬇️
src/window.c	88.98% <0.00%> (-0.04%)	⬇️
src/gui_gtk_x11.c	57.78% <0.00%> (ø)
src/memfile_test.c	100.00% <0.00%> (ø)
... and 8 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a1637f...df5f6b8. Read the comment docs.

[Yegappan Lakshmanan]

@yegappan pushed 1 commit.

• c6dbd37 Add heredoc test for various embedded languges

—
You are receiving this because you are subscribed to this thread.

[Yegappan Lakshmanan]

@yegappan pushed 1 commit.

• a665189 Update test86.in and test87.in to use the new heredoc syntax

—
You are receiving this because you are subscribed to this thread.

[Yegappan Lakshmanan]

Hi Bram,

On Mon, Apr 13, 2020 at 11:01 AM Bram Moolenaar <vim-dev...@256bit.org> wrote:

Supporting "trim" for the interfaces is lacking tests.

I have updated the PR with new heredoc tests for all the embedded languages. 

I have also updated the existing heredoc usage in the test scripts.

- Yegappan

[vim-dev ML]

[Bram Moolenaar]

Closed #5916 via 6c2b7b8.

—
You are receiving this because you commented.