[vim/vim] "REM" is actually a comment, similar to "--" (Issue #11143)

3 views
Skip to first unread message

Carsten Czarski

unread,
Sep 16, 2022, 6:24:02 AM9/16/22
to vim/vim, Subscribed

https://github.com/vim/vim/blob/dd674774bbe3774ff41b817bee0e32060ebcfdad/runtime/syntax/plsql.vim#L471

So wouldn't it be more appropriate to highlight these lines as comment, similar to "--"...?


Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/11143@github.com>

Bram Moolenaar

unread,
Sep 16, 2022, 7:42:23 AM9/16/22
to vim/vim, Subscribed

@lee-lindley


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/11143/1249261459@github.com>

Lee Lindley

unread,
Sep 16, 2022, 9:51:30 AM9/16/22
to vim/vim, Subscribed

REMark is a sqlplus comment command when it occurs at the beginning of a line. It is neither sql nor pl/sql. I am not sure why REM is in the list of reserved or non reserved words I snagged from the oracle sql and plsql documentation. The only similar built-in is the REMAINDER function (complement of mod).

I'm not especially interested in supporting the full arcane breadth of sqlplus; however, we already support some sqlplus syntax like '&' so I can't stand piously on language purity. If you submit a pull request to https://github.com/lee-lindley/vim_plsql_syntax I'll likely include in next release. If that is outside your comfort zone, at least open the issue there and close this one.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/11143/1249391186@github.com>

Lee Lindley

unread,
Sep 16, 2022, 9:56:56 AM9/16/22
to vim/vim, Subscribed

And thanks for bringing it up! Sorry if I came across as grumpy. I'm glad someone is trying it out and noticing stuff.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/11143/1249397234@github.com>

Carsten Czarski

unread,
Sep 16, 2022, 10:36:09 AM9/16/22
to vim/vim, Subscribed

No worries. Let me do a pull request (within the next few days) and post it here, once done.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/11143/1249450073@github.com>

Carsten Czarski

unread,
Sep 17, 2022, 10:44:44 AM9/17/22
to vim/vim, Subscribed

Added PR: lee-lindley/vim_plsql_syntax#1


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/11143/1250083750@github.com>

Reply all
Reply to author
Forward
0 new messages