Commit: patch 9.1.2081: MS-Windows: unnecessary "#ifdef FEAT_GUI" in os_win32.c

2 views
Skip to first unread message

Christian Brabandt

unread,
Jan 12, 2026, 2:16:11 PM (11 hours ago) Jan 12
to vim...@googlegroups.com
patch 9.1.2081: MS-Windows: unnecessary "#ifdef FEAT_GUI" in os_win32.c

Commit: https://github.com/vim/vim/commit/47c84295bb0444bc03598e82965c6175f8b96226
Author: Muraoka Taro <koron....@gmail.com>
Date: Sun Jan 11 19:44:06 2026 +0000

patch 9.1.2081: MS-Windows: unnecessary "#ifdef FEAT_GUI" in os_win32.c

Problem: MS-Windows: "#ifdef FEAT_GUI" exists within "ifdef
FEAT_GUI_MSWIN", which is confusing when reading the code.
FEAT_GUI is always defined if FEAT_GUI_MSWIN is defined (see
vim.h). Therefore, this check and the else block are
unnecessary.
Solution: Removed unnecessary "#ifdef FEAT_GUI" (Muraoka Taro).

closes: #19164

Signed-off-by: Muraoka Taro <koron....@gmail.com>
Signed-off-by: Christian Brabandt <c...@256bit.org>

diff --git a/src/os_win32.c b/src/os_win32.c
index 83f1b1ce3..9526a6ae9 100644
--- a/src/os_win32.c
+++ b/src/os_win32.c
@@ -4848,7 +4848,6 @@ mch_system_classic(char *cmd, int options)

// Wait for the command to terminate before continuing
{
-# ifdef FEAT_GUI
int delay = 1;

// Keep updating the window while waiting for the shell to finish.
@@ -4872,9 +4871,6 @@ mch_system_classic(char *cmd, int options)
if (delay < 50)
delay += 10;
}
-# else
- WaitForSingleObject(pi.hProcess, INFINITE);
-# endif

// Get the command exit code
GetExitCodeProcess(pi.hProcess, &ret);
diff --git a/src/version.c b/src/version.c
index 61e94f5eb..126e1cf77 100644
--- a/src/version.c
+++ b/src/version.c
@@ -734,6 +734,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
+/**/
+ 2081,
/**/
2080,
/**/
Reply all
Reply to author
Forward
0 new messages