[vim/vim] libvterm: signed integer overflow parsing long CSI arguments (PR #19894)

[Christian Brabandt]

Problem: Accumulating CSI argument digits without an upper bound causes
signed integer overflow when the argument exceeds LONG_MAX.
Solution: Skip further digit accumulation once the value would overflow
LONG_MAX.

Supported by AI

---

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/19894

Commit Summary

• 20cccb9 libvterm: signed integer overflow parsing long CSI arguments

File Changes

(1 file)

• M src/libvterm/src/parser.c (7)

Patch Links:

• https://github.com/vim/vim/pull/19894.patch
• https://github.com/vim/vim/pull/19894.diff

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19894@github.com>

[mattn]

mattn left a comment (vim/vim#19894)

I assume the (LONG_MAX - 9) / 10 style check was meant to avoid signed overflow in arg * 10 + digit. But I do not think that is quite the right boundary for CSI args here, since the parser is not really using the full long value domain for numeric arguments.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19894/c4181153527@github.com>