[vim/vim] Add additional tests for normal.c based on code coverage (#5751)

24 views
Skip to first unread message

Yegappan Lakshmanan

unread,
Mar 8, 2020, 3:19:06 PM3/8/20
to vim/vim, Subscribed

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/5751

Commit Summary

  • Add additional tests

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Yegappan Lakshmanan

unread,
Mar 8, 2020, 4:21:27 PM3/8/20
to vim/vim, Push

@yegappan pushed 1 commit.

  • 2dbd490 Increase the size of the window for test

—
You are receiving this because you are subscribed to this thread.

View it on GitHub or unsubscribe.

Yegappan Lakshmanan

unread,
Mar 8, 2020, 11:56:56 PM3/8/20
to vim/vim, Push

@yegappan pushed 1 commit.

—
You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,
Mar 9, 2020, 2:31:33 AM3/9/20
to vim/vim, Push

@yegappan pushed 1 commit.

—
You are receiving this because you are subscribed to this thread.

Codecov

unread,
Mar 9, 2020, 2:53:53 AM3/9/20
to vim/vim, Subscribed

Codecov Report

Merging #5751 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@

##           master    #5751     +/-   ##

=========================================

+ Coverage   84.26%   84.36%   +0.1%     

=========================================

  Files         138      138             

  Lines      152458   152458             

=========================================

+ Hits       128469   128624    +155     

+ Misses      23989    23834    -155
Impacted Files Coverage Δ
src/if_xcmdsrv.c 86.17% <0%> (-0.18%) ⬇️
src/drawline.c 84.67% <0%> (-0.14%) ⬇️
src/terminal.c 82.61% <0%> (+0.03%) ⬆️
src/gui.c 63.68% <0%> (+0.05%) ⬆️
src/diff.c 84.64% <0%> (+0.06%) ⬆️
src/window.c 88.76% <0%> (+0.06%) ⬆️
src/channel.c 84.07% <0%> (+0.07%) ⬆️
src/ui.c 72.49% <0%> (+0.08%) ⬆️
src/search.c 84.23% <0%> (+0.11%) ⬆️
src/buffer.c 86.73% <0%> (+0.2%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 693e80e...8abb9d5. Read the comment docs.

Yegappan Lakshmanan

unread,
Mar 9, 2020, 11:25:20 AM3/9/20
to vim/vim, Push

@yegappan pushed 2 commits.

  • abac405 Add additional test
  • 61bf411 Remove swap files when the arglist test fails

—
You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,
Mar 9, 2020, 3:46:21 PM3/9/20
to vim/vim, Push

@yegappan pushed 1 commit.

  • 0c0a28b Discard changes in the buffer before changing the encoding

—
You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,
Mar 9, 2020, 11:21:35 PM3/9/20
to vim/vim, Push

@yegappan pushed 1 commit.

  • fd1ec50 Add a few additional tests

—
You are receiving this because you are subscribed to this thread.

Bram Moolenaar

unread,
Mar 10, 2020, 2:49:02 AM3/10/20
to vim/vim, Subscribed

Closed #5751 via 1671f44.

Christian Brabandt

unread,
Mar 10, 2020, 3:15:15 AM3/10/20
to vim/vim, Subscribed

wow, a lot of new tests. Nice work!

Yegappan Lakshmanan

unread,
Mar 10, 2020, 6:12:33 AM3/10/20
to vim_dev, reply+ACY5DGFA66GARS5UEZ...@reply.github.com, vim/vim, Subscribed
Hi Christian,

On Tue, Mar 10, 2020 at 12:15 AM Christian Brabandt <vim-dev...@256bit.org> wrote:

wow, a lot of new tests. Nice work!



Thanks.  Your work already covered most of the normal.c functionality
several years back. This latest set of tests increase the coverage to > 90%.

Regards,
Yegappan

vim-dev ML

unread,
Mar 10, 2020, 6:13:01 AM3/10/20
to vim/vim, vim-dev ML, Your activity
Reply all
Reply to author
Forward
0 new messages