[vim/vim] Update sshdconfig syntax (PR #19347)
Fionn
We add new keywords from sshd_config.5 not present here and remove keywords present here that are not present in the official documentation, with the exception of DebianBanner, GSSAPIStoreCredentialsOnRekey and PubkeyAcceptedKeyTypes which are patched into Debian's version, as well as ChallengeResponseAuthentication which is deprecated but still functional.
We also add enums for the PubkeyAuthOptions keyword.
Lastly, we add mlkem768x25519-sha256 as a key exchange algorithm, added to OpenSSH 9.9 and made default in OpenSSH 10.0.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/19347
Commit Summary
- bc43745 Add mlkem768x25519-sha256 as sshdconfigKexAlgo
- e33ef90 Add sshdconfig PubkeyAuthOptions enums
- 7deeda7 Update sshdconfig keywords
File Changes
(1 file)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19347)Did you check with the maintainer?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Fionn
fionn left a comment (vim/vim#19347)Ah, right, I did not. I will email them, wasn't sure of the process.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Jakub Jelen
@Jakuje commented on this pull request.
Thank you for the update of the file! Sorry, I am not that active anymore in here. Few inline notes as some of the stuff you removed are still present in Fedora and there are few new parts that might be worth adding once we touch this.
In runtime/syntax/sshdconfig.vim:
> -syn keyword sshdconfigKeyword GSSAPIEnablek5users -syn keyword sshdconfigKeyword GSSAPIKexAlgorithms -syn keyword sshdconfigKeyword GSSAPIKeyExchange
Please, keep these around. Even though they are not in debian, they are still in other distributions such as Fedora:
https://src.fedoraproject.org/rpms/openssh/blob/rawhide/f/0011-openssh-9.6p1-gssapi-keyex.patch#_3730
In runtime/syntax/sshdconfig.vim:
> syn keyword sshdconfigKeyword UsePAM syn keyword sshdconfigKeyword VersionAddendum syn keyword sshdconfigKeyword X11DisplayOffset syn keyword sshdconfigKeyword X11Forwarding -syn keyword sshdconfigKeyword X11MaxDisplays
This looks like still existing in Fedora/RHEL:
https://src.fedoraproject.org/rpms/openssh/blob/rawhide/f/0051-openssh-7.3p1-x11-max-displays.patch
In runtime/syntax/sshdconfig.vim:
> @@ -121,6 +123,7 @@ syn keyword sshdconfigKexAlgo diffie-hellman-group-exchange-sha256 syn keyword sshdconfigKexAlgo ecdh-sha2-nistp256 syn keyword sshdconfigKexAlgo ecdh-sha2-nistp384 syn keyword sshdconfigKexAlgo ecdh-sha2-nistp521 +syn keyword sshdconfigKexAlgo mlkem768x25519-sha256
The Fedora/RHEL adds also mlkem768nistp256-sha256 and mlkem1024nistp384-sha384 so once we touch it, it would be great if they can be added too:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.