[vim/vim] Problem: backupcopy=auto writes in place with a restrictive umask (PR #21137)
dwivedipranav-dev
The 'backupcopy' auto probe compares the probe file mode to the original
without trying to set the mode. With umask 0077, open(..., 0644) creates
0600, the check fails, and Vim overwrites the original inode.
This tries fchmod() (or mch_setperm()) after fchown().
A test in test_writefile.vim asserts the inode changes and mode stays 0644.
Related: https://redhat.atlassian.net/browse/RHEL-122841
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/21137
Commit Summary
- 8f2c5e4 Problem: backupcopy=auto overwrites a file in place when umask is restrictive.
File Changes
(2 files)
- M src/bufwrite.c (7)
- M src/testdir/test_writefile.vim (22)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
dwivedipranav-dev
dwivedipranav-dev left a comment (vim/vim#21137)Thanks, applied. There is now a single blank line between the tests and before the modeline.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#21137)thanks
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.