[vim/vim] refactor: change boolean win_T members from int/char to bool (PR #20008)
h_east
Problem:
Several win_T fields are declared as "int" or "char" but are used strictly as boolean flags with TRUE/FALSE values. The integer types obscure the boolean intent and are wider than needed.
Solution:
Change the following win_T members to bool (stdbool.h) and update their assignments from TRUE/FALSE to true/false accordingly.
-
int -> bool (10 members): w_set_curswant, w_botfill, w_old_botfill, w_do_win_fix_cursor, w_popup_fixed, w_border_highlight_isset, w_cline_folded, w_redr_status, w_arg_idx_invalid, w_has_scrollbar
-
char -> bool (4 members): w_topline_was_set, w_ru_empty, w_fold_manual, w_foldinvalid
No existing code compares these members against TRUE/FALSE explicitly or uses ++/-- / bitwise ops on them, so only plain assignments are affected.
Excluded: w_locked (recursion counter with ++/--), w_want_scrollbar (may hold -1 from dict_get_bool), w_winbar_height (used in arithmetic and exposed as number via getwininfo()).
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/20008
Commit Summary
- 6f9a2e0 refactor: change boolean win_T members from int/char to bool
File Changes
(36 files)
- M src/arglist.c (4)
- M src/buffer.c (12)
- M src/diff.c (4)
- M src/drawline.c (2)
- M src/drawscreen.c (20)
- M src/edit.c (24)
- M src/evalfunc.c (6)
- M src/evalwindow.c (4)
- M src/ex_cmds.c (2)
- M src/ex_docmd.c (2)
- M src/ex_getln.c (4)
- M src/fold.c (18)
- M src/if_lua.c (2)
- M src/if_mzsch.c (2)
- M src/if_ruby.c (2)
- M src/if_tcl.c (2)
- M src/indent.c (2)
- M src/memline.c (2)
- M src/misc1.c (2)
- M src/misc2.c (2)
- M src/mouse.c (8)
- M src/move.c (8)
- M src/normal.c (72)
- M src/ops.c (8)
- M src/option.c (4)
- M src/optionstr.c (4)
- M src/popupmenu.c (4)
- M src/popupwin.c (12)
- M src/quickfix.c (4)
- M src/register.c (2)
- M src/screen.c (8)
- M src/search.c (4)
- M src/structs.h (28)
- M src/tag.c (4)
- M src/terminal.c (4)
- M src/window.c (18)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#20008)thanks
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.