May be incorrect JPMS module-info entries

[Himanshu Gupta]

Hi,

Do we really need these ? This is breaking a pure JPMS based application and I have to include micrometer graphite, influx and .. even though they are not needed

https://github.com/vert-x3/vertx-micrometer-metrics/blob/d99644e6b3e936481ae3971f2831c88cefc33726/src/main/java/module-info.java#L13-L16

https://github.com/vert-x3/vertx-micrometer-metrics/blob/d99644e6b3e936481ae3971f2831c88cefc33726/src/main/java/module-info.java#L8

Thanks,

Himanshu

[Thomas SEGISMONT]

Hi,

Good point, perhaps these should be "requires static", because we need the modules for compilation at least.

Can you file an issue to the corresponding repository please?

Thanks,

Thomas

--
You received this message because you are subscribed to the Google Groups "vert.x" group.
To unsubscribe from this group and stop receiving emails from it, send an email to vertx+un...@googlegroups.com.
To view this discussion, visit https://groups.google.com/d/msgid/vertx/7eee32f5-f84a-42ca-81b0-89f48bd0272an%40googlegroups.com.