--
You received this message because you are subscribed to the Google Groups "vert.x" group.
To unsubscribe from this group and stop receiving emails from it, send an email to vertx+un...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
I'm not sure if we really need access to these headers.
Now, one thing that is useful and that I don't think vertx websockets allows for is params passed through the query part of the URL. I might be wrong here, but the ws/wss url spec seems to allow for the same parts of a normal HTTP URL with the exception of # (anchors). I did a quick ws app to check if this was happening and I can only see the path part of the ws URL reflected in the ServerWebSocket. Shouldn't the query part be exposed through the interface?
What do you need this for?I'm using HttpServer created from vertx instance
def httpServer = vertx.createHttpServer()with routes set via RouteMatcher. Then in handler of every registered request I have HttpServerRequest with all stuff, especially with headers.Do you consider this as I solution? I could post here some code.
2013/3/30 froz3n <bmros...@gmail.com>
I'm not sure if we really need access to these headers.The need depends on the case. Since it's a part of WebSocket, then it's just simply missing in Vert.x, right?
Now, one thing that is useful and that I don't think vertx websockets allows for is params passed through the query part of the URL. I might be wrong here, but the ws/wss url spec seems to allow for the same parts of a normal HTTP URL with the exception of # (anchors). I did a quick ws app to check if this was happening and I can only see the path part of the ws URL reflected in the ServerWebSocket. Shouldn't the query part be exposed through the interface?
That's a completely different case. Still, Headers are part of WebSockets. Other frameworks seem to implement this feature,
so I don't see the point in asking the user whether he actually needs them :-)
, so it seems like an obvious miss.
I think he refer to the http headers that are part of the handshake�
If not then I have no clue ;)
Bye,Norman
Am 30.03.2013 um 21:28 schrieb Tim Fox <timv...@gmail.com>:
On 30/03/13 11:14, Wojciech Erbetowski wrote:
Hey Bartek,
What do you need this for?I'm using HttpServer created from vertx instanceYeah, HttpServer works fine in this particular case, but the WebSocketServer doesn't :-(I need them for the same stuff you need headers in HTTP, e.g. session, client application distingish, ...
def httpServer = vertx.createHttpServer()
with routes set via RouteMatcher. Then in handler of every registered request I have�HttpServerRequest with all stuff, especially with headers.
Do you consider this as I solution? I could post here some code.
But we have the communication based on WebSocket, currently based on JWebSocket.My intention was to migrate to vert.x, which seemed quite cool, although this is a blocker for me.Not using headers means changing the client applications (mobile apps) and that's a completely different story :-)
As far as I see most of stable WS implementations handle the headers
Really? Can you cite some references?
--, so it seems like an obvious miss.
You received this message because you are subscribed to the Google Groups "vert.x" group.
To unsubscribe from this group and stop receiving emails from it, send an email to vertx+un...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
�
�
--
You received this message because you are subscribed to the Google Groups "vert.x" group.
To unsubscribe from this group and stop receiving emails from it, send an email to vertx+un...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
�
�
--
You received this message because you are subscribed to the Google Groups "vert.x" group.
To unsubscribe from this group and stop receiving emails from it, send an email to vertx+un...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
�
�
On 30/03/13 20:38, Norman Maurer wrote:
I think he refer to the http headers that are part of the handshake…
Those headers are an implementation detail of the protocol, and not something that can be used to convey application level information, so I can't see any good reason to expose them.
If not then I have no clue ;)
Me neither :)
Bye,Norman
Am 30.03.2013 um 21:28 schrieb Tim Fox <timv...@gmail.com>:
On 30/03/13 11:14, Wojciech Erbetowski wrote:
Hey Bartek,
What do you need this for?I'm using HttpServer created from vertx instanceYeah, HttpServer works fine in this particular case, but the WebSocketServer doesn't :-(I need them for the same stuff you need headers in HTTP, e.g. session, client application distingish, ...
def httpServer = vertx.createHttpServer()
with routes set via RouteMatcher. Then in handler of every registered request I have HttpServerRequest with all stuff, especially with headers.
Do you consider this as I solution? I could post here some code.
But we have the communication based on WebSocket, currently based on JWebSocket.My intention was to migrate to vert.x, which seemed quite cool, although this is a blocker for me.Not using headers means changing the client applications (mobile apps) and that's a completely different story :-)
As far as I see most of stable WS implementations handle the headers
Really? Can you cite some references?
--, so it seems like an obvious miss.
You received this message because you are subscribed to the Google Groups "vert.x" group.
To unsubscribe from this group and stop receiving emails from it, send an email to vertx+un...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
--
You received this message because you are subscribed to the Google Groups "vert.x" group.
To unsubscribe from this group and stop receiving emails from it, send an email to vertx+un...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
--
You received this message because you are subscribed to the Google Groups "vert.x" group.
To unsubscribe from this group and stop receiving emails from it, send an email to vertx+un...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
You can access them on the WebSocket JSR API � But to be honest I'm not a big fan of the API ;)
Am 30.03.2013 um 21:40 schrieb Tim Fox <timv...@gmail.com>:
On 30/03/13 20:38, Norman Maurer wrote:
I think he refer to the http headers that are part of the handshake�
Those headers are an implementation detail of the protocol, and not something that can be used to convey application level information, so I can't see any good reason to expose them.
If not then I have no clue ;)
Me neither :)
Bye,Norman
Am 30.03.2013 um 21:28 schrieb Tim Fox <timv...@gmail.com>:
On 30/03/13 11:14, Wojciech Erbetowski wrote:
Hey Bartek,
What do you need this for?I'm using HttpServer created from vertx instanceYeah, HttpServer works fine in this particular case, but the WebSocketServer doesn't :-(I need them for the same stuff you need headers in HTTP, e.g. session, client application distingish, ...
def httpServer = vertx.createHttpServer()
with routes set via RouteMatcher. Then in handler of every registered request I have�HttpServerRequest with all stuff, especially with headers.
Do you consider this as I solution? I could post here some code.
But we have the communication based on WebSocket, currently based on JWebSocket.My intention was to migrate to vert.x, which seemed quite cool, although this is a blocker for me.Not using headers means changing the client applications (mobile apps) and that's a completely different story :-)
As far as I see most of stable WS implementations handle the headers
Really? Can you cite some references?
--, so it seems like an obvious miss.
You received this message because you are subscribed to the Google Groups "vert.x" group.
To unsubscribe from this group and stop receiving emails from it, send an email to vertx+un...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
�
�
--
You received this message because you are subscribed to the Google Groups "vert.x" group.
To unsubscribe from this group and stop receiving emails from it, send an email to vertx+un...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
�
�
--
You received this message because you are subscribed to the Google Groups "vert.x" group.
To unsubscribe from this group and stop receiving emails from it, send an email to vertx+un...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
�
�
--
You received this message because you are subscribed to the Google Groups "vert.x" group.
To unsubscribe from this group and stop receiving emails from it, send an email to vertx+un...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
�
�
--
You received this message because you are subscribed to the Google Groups "vert.x" group.
To unsubscribe from this group and stop receiving emails from it, send an email to vertx+un...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
�
�
On 30/03/13 20:42, Norman Maurer wrote:
You can access them on the WebSocket JSR API � But to be honest I'm not a big fan of the API ;)
Ok, but I'm guessing the vast majority of websockets users are using websockets from a browser where there is no API to set headers. Those users who are using a Java websocket client where headers can be set are probably in a very small minority, and if they write their app to rely on headers being set on the client then it's not going to be portable to browsers.
Yes, you're right. Just open an issue on github and eventually someone will get to it (hopefully before 2.0 is released).
On 30/03/13 20:42, Norman Maurer wrote:
You can access them on the WebSocket JSR API … But to be honest I'm not a big fan of the API ;)
Ok, but I'm guessing the vast majority of websockets users are using websockets from a browser where there is no API to set headers. Those users who are using a Java websocket client where headers can be set are probably in a very small minority, and if they write their app to rely on headers being set on the client then it's not going to be portable to browsers.
I'd say the request might have value but it's an edge case.
Really? Can you cite some references?As far as I see most of stable WS implementations handle the headers
>> You can access them on the WebSocket JSR API � But to be honest I'm not
>> a big fan of the API ;)
>>
>>
>> Ok, but I'm guessing the vast majority of websockets users are using
>> websockets from a browser where there is no API to set headers. Those users
>> who are using a Java websocket client where headers can be set are probably
>> in a very small minority, and if they write their app to rely on headers
>> being set on the client then it's not going to be portable to browsers.
>>
>> I'd say the request might have value but it's an edge case.
>>
>>
>> Am 30.03.2013 um 21:40 schrieb Tim Fox <timv...@gmail.com <javascript:>>:
>>
>> On 30/03/13 20:38, Norman Maurer wrote:
>>
>> I think he refer to the http headers that are part of the handshake�
>>
>>
>> Those headers are an implementation detail of the protocol, and not
>> something that can be used to convey application level information, so I
>> can't see any good reason to expose them.
>>
>> If not then I have no clue ;)
>>
>>
>> Me neither :)
>>
>>
>> Bye,
>> Norman
>>
>> Am 30.03.2013 um 21:28 schrieb Tim Fox <timv...@gmail.com <javascript:>>:
>>
>> On 30/03/13 11:14, Wojciech Erbetowski wrote:
>>
>> Hey Bartek,
>>
>> 2013/3/29 Bartek Zdanowski <bartek.z...@gmail.com <javascript:>>
>>
>>> What do you need this for?
>>> I'm using HttpServer created from vertx instance
>>>
>> Yeah, HttpServer works fine in this particular case, but the
>> WebSocketServer doesn't :-(
>> I need them for the same stuff you need headers in HTTP, e.g. session,
>> client application distingish, ...
>>
>> def httpServer = vertx.createHttpServer()
>>>
>>> with routes set via RouteMatcher. Then in handler of every registered
>>> request I have�HttpServerRequest with all stuff, especially with headers.
>>>
>>> Do you consider this as I solution? I could post here some code.
>>>
>> But we have the communication based on WebSocket, currently based on
>> JWebSocket.
>> My intention was to migrate to vert.x, which seemed quite cool, although
>> this is a blocker for me.
>> Not using headers means changing the client applications (mobile apps) and
>> that's a completely different story :-)
>>
>> As far as I see most of stable WS implementations handle the headers
>>
>>
>> Really? Can you cite some references?
>>
>> , so it seems like an obvious miss.
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "vert.x" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to vertx+un...@googlegroups.com <javascript:>.
>> For more options, visit https://groups.google.com/groups/opt_out.
>> �
>> �
>>
>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "vert.x" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to vertx+un...@googlegroups.com <javascript:>.
>> For more options, visit https://groups.google.com/groups/opt_out.
>> �
>> �
>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "vert.x" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to vertx+un...@googlegroups.com <javascript:>.
>> For more options, visit https://groups.google.com/groups/opt_out.
>> �
>> �
>>
>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "vert.x" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to vertx+un...@googlegroups.com <javascript:>.
>> For more options, visit https://groups.google.com/groups/opt_out.
>> �
>> �
>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "vert.x" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to vertx+un...@googlegroups.com <javascript:>.
>> For more options, visit https://groups.google.com/groups/opt_out.
>> �
>> �
>>
>>
>>