-DVERTXWEB_ENVIRONMENT=dev is no longer working

[RCoe]

I recall in 3.5 that the -DVERTXWEB_ENVIRONMENT=dev runtime parameter, to disable caching behaviour, allowed me to save static html and reload my browser to see the change.  I can no longer get this to work in 4.0.

I am using vsCode and building with maven.  When I save my source:

> src/resources/webroot/index.html

it gets copied automatically to:

> target/resources/webroot/index.html

However, my browser is not picking up the change without restarting my HTTP verticle.  I have confirmed that my browser (Edge) is not caching files when the developer pane is open.

The command that starts my verticles is created by the vsCode debug lens:

> /usr/bin/env /usr/lib/jvm/java-11-openjdk-amd64/bin/java -agentlib:jdwp=transport=dt_socket,server=n,suspend=y,address=localhost:44109 -Dvertx.disableDnsResolver=true -DVERTXWEB_ENVIRONMENT=dev -Dfile.encoding=UTF-8 @/tmp/cp_1nyqaeh6y4ers5nwp6cv6z9k6.argfile ca.linkedtutoring.chat.MainVerticle -conf /d/cygwin64/home/rcoe/linked/conf/config.json

Am I missing something obvious?

Thanks

[GERARD Nicolas]

In master (4x), I can see still that it will react to this env.

Line:

https://github.com/vert-x3/vertx-web/blob/master/vertx-web-common/src/main/java/io/vertx/ext/web/common/template/CachingTemplateEngine.java#L35

That calls:

https://github.com/vert-x3/vertx-web/blob/f173a34aa726cb3abd8ece6abc4cc8d10738e22d/vertx-web-common/src/main/java/io/vertx/ext/web/common/WebEnvironment.java#L44

And that expects as env variabe:

VERTXWEB_ENVIRONMENT

but as system:

vertxweb.environment

Don't ask me why but this is what this is.

Try to change your command to:

-Dvertxweb.environment=dev

Cheers

Nico

[Robin Coe]

The linked code is for vertx3 but I used your idea to investigate the vertx 4 code.  Attached below is the method that is called when starting the vertical:

public interface WebEnvironment {

  String SYSTEM_PROPERTY_NAME = "vertxweb.environment";

  String ENV_VARIABLE_NAME = "VERTXWEB_ENVIRONMENT";

  /**

   * Will return true if the mode is not null and equals ignoring case the string "dev"

   * @return always boolean

   */

  static boolean development() {

    final String mode = mode();

    return "dev".equalsIgnoreCase(mode) || "Development".equalsIgnoreCase(mode);

  }

  /**

   * The current mode from the system properties with fallback to environment variables

   * @return String with mode value or null

   */

  static @Nullable String mode() {

    return System.getProperty(SYSTEM_PROPERTY_NAME, System.getenv(ENV_VARIABLE_NAME));

  }

}

In the case of starting the JVM with -D, we're dealing with an environment variable not a system property, so it should be upper case.  And, in fact, putting a breakpoint on this line that checks the value of "mode" confirms that development() returns true.  So I was using the correct environment variable name,   But even though this method returns true, I still do not see my code changes picked up by the verticle handling my static resources:

        router.route().handler( StaticHandler.create() );

Strange thing is, I don't see a meta tag for cache behaviour in my rendered page:

<meta charset="UTF-8"> <meta name="viewport" content="width=device-width, initial-scale=1.0">

I'd expect to see these tags added in dev mode, to disable browser caching:

<meta http-equiv="Cache-Control" content="no-cache, no-store, must-revalidate" />
<meta http-equiv="Pragma" content="no-cache" />
<meta http-equiv="Expires" content="0" />

But the browser cache behaviour isn't involved in this case.

--
You received this message because you are subscribed to a topic in the Google Groups "vert.x" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/vertx/MvN6CTpRvfw/unsubscribe.
To unsubscribe from this group and all its topics, send an email to vertx+un...@googlegroups.com.
To view this discussion on the web, visit https://groups.google.com/d/msgid/vertx/fa46c78e-9ddf-45f2-8c62-5077c2833598n%40googlegroups.com.

[Paulo Lopes]

The web environment flag doesn't change template content. We could however on the static handler disable cache headers in dev mode. But this won't affect template generated content

[Paulo Lopes]

After double-checking, this is in fact already like this:

/**
* Default of whether cache header handling is enabled
*/
boolean DEFAULT_CACHING_ENABLED = !WebEnvironment.development();

[Robin Coe]

Could be my expectations of hotspot behaviour, coming to vscode from Eclipse, in that hot-swapping code into the runtime avoids restarting the JVM.  Although vscode uses the same server, I'd think that would be accommodated.  As it is, I need to restart my vertices to pick up any code changes, server or client.

As far as the browser <meta> tags are concerned, I'd think template engines, in general, should match what JSPs use, regardless of dev mode.  In the case of dev mode, though, the meta tags should inform the browser to not cache static resources.

To view this discussion on the web, visit https://groups.google.com/d/msgid/vertx/a2839dbb-a2e1-4abd-b08a-c5580cabb3aan%40googlegroups.com.