Vert.x Micrometer Metrics support for InfluxDb 2.0

[Clive Lilley]

Hi,

I have a customer who has deployed InfluxDb 2.0 in to their development environment and has asked if Vertx is ready to support this endpoint yet.

I see that maven reports that the Vert.x Micrometer Metrics artifact (version 4.3.2) has an optional dependency on micrometer-registry-influx version 1.6.2. Are there any plans to upgrade to version 1.8+, which would then support InfluxDb 2.0.

Clive

[Thomas SEGISMONT]

Hi,

Have you tried to change the micrometer version in your project?

In any case, please file an issue on the corresponding GitHub project so that we take care of the upgrade in Vert.x 4.3

Thank you,

Thomas

--
You received this message because you are subscribed to the Google Groups "vert.x" group.
To unsubscribe from this group and stop receiving emails from it, send an email to vertx+un...@googlegroups.com.
To view this discussion on the web, visit https://groups.google.com/d/msgid/vertx/8836770f-2659-4256-a407-a81f8b6fb815n%40googlegroups.com.

[Clive Lilley]

Thomas,

I did try changing the version of micrometer-registry-influx from 1.62 to 1.7+,  a few months back, but this stopped the metrics from working. So I wanted to wait until support for the newer 1.8+ was available.

As you suggest I will file an issue on GitHub.

Thanks.

Clive

[Thomas SEGISMONT]

Thank you

To view this discussion on the web, visit https://groups.google.com/d/msgid/vertx/fcaa12ad-8cb8-48b1-b2cd-c3a52420cd5en%40googlegroups.com.

[Thomas SEGISMONT]

Can you elaborate on the issues you had please?

There is PR which has been submitted: https://github.com/vert-x3/vertx-micrometer-metrics/pull/132

Our test suite did not catch any regression.

[Yeikel]

Clive , could you please give us an update about this?

[Clive Lilley]

I've just started looking at this again after a few months out.

I see that vertx 4.3.1 has been released and this has updated its dependencies to pull in versions 1.8.4 of io.micrometer:micrometer-core which enables io.micrometer:micormeter-registry-influx:1.8.4 to be included. So this should enable vertx 4.3.x to support InfluxDb 2.0 endpoints.

The influxDB 2.0 configuration now uses several new additional properties (io.micrometer.influx.InfluxConfig.java) to configure the influxDb2 endpoint:

• org
• bucket
• token
  

But I do not see that the VertxInfluxDbOptions class has been updated to support these additional properties.

Is there any plan to update the VertxInfluxDbOptions class to support them?

Clive

[Thomas SEGISMONT]

Hi Clive,

Please file an issue to Vert.x Micrometer Metrics repo. Would you like to help by providing a PR? I can assist you in the process.

Thank,

Thomas

To view this discussion on the web, visit https://groups.google.com/d/msgid/vertx/df4397f7-1583-48e2-a734-1e43c900fa5bn%40googlegroups.com.

[Clive Lilley]

Thomas,

I have raised issue https://github.com/vert-x3/vertx-micrometer-metrics/issues/141 to cover the work required to get InfluxDb 2.0 connection support in to Vert.x.

If you can provide some advice on how to provide a PR, more than happy to try and make the required changes.

Clive

[Thomas SEGISMONT]

Thank you, let's continue the conversation on GH.

To view this discussion on the web, visit https://groups.google.com/d/msgid/vertx/6290e8f0-a0f4-4060-90a2-e576955dd432n%40googlegroups.com.