SUnit Browser looses icons/color after image restart

[Marcus Wagner]

A tiny contribution, if anybody else also suffered from this:

To reproduce the case: create SUnit tests, run them and study the test results.

Then leave the Sunit Browser open. save the image and exit it.

Restart the image and the SUnit Browser is in a colorless state, icons are lost.

It is obvious, that several potential test results obtained before are lost after the image save. The browser starts counting from 0 again after restart.

Not so obvious is that all its icons (to signal results) are lost from this moment on.

There are two solutions: 

a) close and reopen the SUnit Browser, the new instance is ok again.

b) apply this patch as repair, as the low level resources are not cleaned up properly after the restart of the image. Create this method in Class JLOEtWindow (scratch edition)

 restartWindowFromSnapshot: widgetHierarchySnapshot

"Restart the receiver, restoring its resources from the given
 widget hierarchy snapshot."

"Clear the widget table so that old icons are not referenced."
resources := nil.
^super restartWindowFromSnapshot: widgetHierarchySnapshot

[Esteban A. Maringolo]

Hi Marcus,

Thank you for sharing this solution. I've tested the provided patch, and it effectively resolves the issue with the SUnit Browser losing icons and colors after an image restart.

I will now create a development case to merge this change and ensure it's included in the next release.

Best regards,

Esteban Maringolo VAST Consultant Senior Software Developer  emari...@instantiations.com  @emaringolo  /emaringolo  instantiations.com

--
You received this message because you are subscribed to the Google Groups "VAST Community Forum" group.
To unsubscribe from this group and stop receiving emails from it, send an email to va-smalltalk...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/va-smalltalk/9dd8a5f1-ba53-4965-914c-51efce84d069n%40googlegroups.com.

[Marcus Wagner]

Hi Esteban,

thank you for propagating my fix. 

To all of you interested in older VASTs than 13 - 14:

In older VAST versions this fix now helps and is slightly better than to close and re-open the browser, but alone it is not perfect.  

It relies on other, older fixes elsewhere. 

In principle, this fix contributes even back in VAST 8.6 as part of the solution, but in VAST 8.6 you still must click to expand the icon tree widget, as initially no icons are shown there, also. 

That means, in addition in older versions also a redraw widget was missing (or event reordering?) ... 

I do not determine in which later VAST the precondition for the fix became active or if it works in VAST 7 or Visual Age 6 or before. 

This is left open.

Kind regards,

Marcus