bazel build v8 version 11.0.226.16 failed with error: 'src/heap/base/stack.h' file

[Yulan Wang]

Hi,

I'm trying to bazel build v8 11.0.226.16 (current chrome stable version) as third party lib in our repo.  I got the error of

Use --sandbox_debug to see verbose messages from the sandbox
external/v8/src/heap/base/asm/x64/save_registers_asm.cc:5:10: error: 'src/heap/base/stack.h' file not found with <angled> include; use "quotes" instead
#include <src/heap/base/stack.h>
         ^~~~~~~~~~~~~~~~~~~~~~~
         "src/heap/base/stack.h"
1 error generated.

Seem other latest version works. To build 11.0.226.16 version, do I need add any flags? Thanks!

best,

Yulan

[Clemens Backes]

That include indeed seems broken. It should use double quotes instead of angled brackets.

This file was added in https://crrev.com/c/3989143 (v10.9) and removed in https://crrev.com/c/4171639 (v11.1), that's why tip of tree works for you.

As the problem was already introduced in v10.9, I am not sure if this deserves a fix on the old branches.

+Nikos Papaspyrou 

--
--
v8-users mailing list
v8-u...@googlegroups.com
http://groups.google.com/group/v8-users
---
You received this message because you are subscribed to the Google Groups "v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-users+u...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/v8-users/fe7a6443-dafc-4ef1-b46d-e6dcda8cb097n%40googlegroups.com.

--

Clemens Backes

Software Engineer

clem...@google.com

Google Germany GmbH

Erika-Mann-Straße 33

80636 München

Geschäftsführer: Paul Manicle, Liana Sebastian   

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, dass die E-Mail an die falsche Person gesendet wurde.

This e-mail is confidential. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person.

[Nikos Papaspyrou]

That's right, I introduced this by mistake in all files under src/heap/base/asm/, probably a glitch of the automatic #include insertion in vscode.

All these files have been now removed.

In fact, the only file I see at ToT that has such an include is:

src/base/debug/stack_trace_android.cc:15:#include <src/base/platform/platform.h>