Question about String::WriteAscii

[r...@tinyclouds.org]

What is the purpose of this line?

http://github.com/ry/node/blob/9922e4e433996722a76edb46d14f1729f33b4bed/deps/v8/src/api.cc#L3005

[fuzzy spoon]

It seems like a safe guard for buffer* having '\0' in it (obviously, i know you knew that).

To me it seems like an issue, because char* uses '\0' to denote the end of the string,

but perhaps writing a buffer or multiple strings in the same buffer was causing problems with 

the strings stopping at string 1, so this was added because the supplied length is explicit.  

ie : it _allows_ you to write strings contiguous in memory provided you know how long they are combined (including the zero-termination for each). 

Perhaps it's a neat trick for performance reasons? 

Im curious - does it impact performance at all? 

Or does it break a normal char* by changing its terminator to a space? 

On Wed, Sep 22, 2010 at 12:28 AM, <r...@tinyclouds.org> wrote:

What is the purpose of this line?

http://github.com/ry/node/blob/9922e4e433996722a76edb46d14f1729f33b4bed/deps/v8/src/api.cc#L3005

--
v8-users mailing list
v8-u...@googlegroups.com
http://groups.google.com/group/v8-users

[Alan Gutierrez]

'\0' is a valid ASCII character.

http://www.klcconsulting.net/ascii.htm

Alan Gutierrez - al...@prettyrobots.com - http://twitter.com/bigeasy

[Camilo Aguilar]

No, it isn't. The valid ascii character is NUL or 000 or 0 in Char, Oct, Dec and Hex respectively.

[Alan Gutierrez]

So, what does '\0' map to in ASCII? Its character code value is 0.

Are you correcting semantics or are you adding something to the discussion?

Alan Gutierrez - al...@prettyrobots.com - http://twitter.com/bigeasy

[Alan Gutierrez]

Seems like this conversation stalled. I'm still curious to learn why
the ASCII encoding arbitrarily converts 0 to 32 when encountered in
the encoding, and if it is such great shakes, why not do it for UTF-8?

In the meantime, I'm zeroing the most significant bit and using the
UTF-8 decoder.

Alan Gutierrez