[builtins] Properly pop args in collection ctors [v8/v8 : main]
0 views
Skip to first unread message
Jakob Linke (Gerrit)
Nov 18, 2025, 8:54:02 AM (24 hours ago) Nov 18
to Igor Sheludko, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Igor Sheludko
Jakob Linke voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jakob Linke
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Igor Sheludko
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Igor Sheludko (Gerrit)
Nov 18, 2025, 9:03:05 AM (23 hours ago) Nov 18
to Jakob Linke, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Jakob Linke
Igor Sheludko voted and added 1 comment![]( "Open in Gerrit")
Votes added by Igor Sheludko
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Attention is currently required from:
- Jakob Linke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Nov 18, 2025, 9:35:10 AM (23 hours ago) Nov 18
to Jakob Linke, Igor Sheludko, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[builtins] Properly pop args in collection ctors
This bug did not surface until now because the call site
in JSBuiltinsConstructStubHelper pops the entire frame after
the builtin has returned.
Change-Id: I304536c69988150ac277de42ea96678bd669196c
Commit-Queue: Jakob Linke <jgr...@chromium.org>
Reviewed-by: Igor Sheludko <ish...@chromium.org>
Auto-Submit: Jakob Linke <jgr...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103792}
Files:
- M src/builtins/builtins-collections-gen.cc
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Igor Sheludko
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages