[snapshot] Don't allocate LO strings in RO space [v8/v8 : main]

0 views
Skip to first unread message

Jakob Linke (Gerrit)

unread,
4:49 AM (7 hours ago) 4:49 AM
to Leszek Swirski, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Leszek Swirski

Jakob Linke added 1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Leszek Swirski
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I4b1690561542d0d64532abed5b616bf5e2babb5b
Gerrit-Change-Number: 7077317
Gerrit-PatchSet: 1
Gerrit-Owner: Jakob Linke <jgr...@chromium.org>
Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Leszek Swirski <les...@chromium.org>
Gerrit-Comment-Date: Thu, 23 Oct 2025 08:49:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Leszek Swirski (Gerrit)

unread,
4:51 AM (7 hours ago) 4:51 AM
to Jakob Linke, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Jakob Linke

Leszek Swirski voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jakob Linke
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I4b1690561542d0d64532abed5b616bf5e2babb5b
Gerrit-Change-Number: 7077317
Gerrit-PatchSet: 1
Gerrit-Owner: Jakob Linke <jgr...@chromium.org>
Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Jakob Linke <jgr...@chromium.org>
Gerrit-Comment-Date: Thu, 23 Oct 2025 08:50:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Jakob Linke (Gerrit)

unread,
5:47 AM (6 hours ago) 5:47 AM
to Leszek Swirski, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com

Jakob Linke voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I4b1690561542d0d64532abed5b616bf5e2babb5b
Gerrit-Change-Number: 7077317
Gerrit-PatchSet: 2
Gerrit-Owner: Jakob Linke <jgr...@chromium.org>
Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Comment-Date: Thu, 23 Oct 2025 09:47:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
6:23 AM (5 hours ago) 6:23 AM
to Jakob Linke, Leszek Swirski, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: test/cctest/test-serialize.cc
Insertions: 6, Deletions: 0.

@@ -941,6 +941,12 @@
}

UNINITIALIZED_TEST(TestCustomSnapshotDataBlobWithLargeObjectString) {
+ if (V8_SINGLE_GENERATION_BOOL) {
+ // The relevant strings are in-place internalized in this mode, and thus
+ // never reach the codepath that allocates them in RO space. Skip the test.
+ return;
+ }
+
i::v8_flags.allow_natives_syntax = true;
std::stringstream ss;
ss << "var short_onebyte_string = %InternalizeString('a'.repeat(128));"
```

Change information

Commit message:
[snapshot] Don't allocate LO strings in RO space

.. since ReadOnlySpace must not contain objects exceeding
kMaxRegularHeapObjectSize.

Also, apply the same logic to two byte internalized strings.
Fixed: 453511294
Change-Id: I4b1690561542d0d64532abed5b616bf5e2babb5b
Reviewed-by: Leszek Swirski <les...@chromium.org>
Commit-Queue: Jakob Linke <jgr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103308}
Files:
  • M src/heap/factory-base.cc
  • M test/cctest/test-serialize.cc
Change size: M
Delta: 2 files changed, 84 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Leszek Swirski
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I4b1690561542d0d64532abed5b616bf5e2babb5b
Gerrit-Change-Number: 7077317
Gerrit-PatchSet: 3
Gerrit-Owner: Jakob Linke <jgr...@chromium.org>
Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages