[wasm][common] Use StrongAlias for boolean-like enums [v8/v8 : main]

[Clemens Backes (Gerrit)]

Attention needed from Leszek Swirski

Clemens Backes added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Clemens Backes . resolved

As discussed in chat, let's finally do this!
I guess there's no better way than one big CL, so here it is...

Open in Gerrit

Related details

Attention is currently required from:

• Leszek Swirski

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement
• SLSA-Policy-Verified

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Id703bdd17327b46177b74ffd633f3362a1c2b503

Gerrit-Change-Number: 8005975

Gerrit-PatchSet: 4

Gerrit-Owner: Clemens Backes <clem...@chromium.org>

Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>

Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>

Gerrit-CC: Hannes Payer <hpa...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: v8-s...@luci-project-accounts.iam.gserviceaccount.com <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Leszek Swirski <les...@chromium.org>

Gerrit-Comment-Date: Tue, 30 Jun 2026 15:05:33 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Maksim Ivanov (Gerrit)]

Attention needed from Clemens Backes and Leszek Swirski

Maksim Ivanov added 1 comment

File src/baseline/baseline-compiler.h

Line 192, Patchset 4 (Latest): struct MarkAsIndirectJumpTargetTag;

Maksim Ivanov . unresolved

I think explicitly declaring the tag shouldn't be needed?

Open in Gerrit

Related details

Attention is currently required from:

• Clemens Backes
• Leszek Swirski

Submit Requirements:

• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

• SLSA-Policy-Verified

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Id703bdd17327b46177b74ffd633f3362a1c2b503

Gerrit-Change-Number: 8005975

Gerrit-PatchSet: 4

Gerrit-Owner: Clemens Backes <clem...@chromium.org>

Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>

Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>

Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>

Gerrit-CC: Hannes Payer <hpa...@chromium.org>

Gerrit-CC: Maksim Ivanov <em...@google.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: v8-s...@luci-project-accounts.iam.gserviceaccount.com <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Clemens Backes <clem...@chromium.org>

Gerrit-Attention: Leszek Swirski <les...@chromium.org>

Gerrit-Comment-Date: Tue, 30 Jun 2026 15:22:22 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Clemens Backes (Gerrit)]

Attention needed from Leszek Swirski and Maksim Ivanov

Clemens Backes added 1 comment

File src/baseline/baseline-compiler.h

Line 192, Patchset 4: struct MarkAsIndirectJumpTargetTag;

Maksim Ivanov . resolved

I think explicitly declaring the tag shouldn't be needed?

Clemens Backes

Nice, done!

Open in Gerrit

Related details

Attention is currently required from:

• Leszek Swirski
• Maksim Ivanov

Submit Requirements:

• Code-Owners
• Code-Review

• Review-Enforcement
• SLSA-Policy-Verified

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Id703bdd17327b46177b74ffd633f3362a1c2b503

Gerrit-Change-Number: 8005975

Gerrit-PatchSet: 7

Gerrit-Owner: Clemens Backes <clem...@chromium.org>

Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>

Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>

Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>

Gerrit-CC: Hannes Payer <hpa...@chromium.org>

Gerrit-CC: Maksim Ivanov <em...@google.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: v8-s...@luci-project-accounts.iam.gserviceaccount.com <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Maksim Ivanov <em...@google.com>

Gerrit-Attention: Leszek Swirski <les...@chromium.org>

Gerrit-Comment-Date: Wed, 01 Jul 2026 10:25:43 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Maksim Ivanov <em...@google.com>

[Maksim Ivanov (Gerrit)]

Attention needed from Clemens Backes and Leszek Swirski

Maksim Ivanov added 1 comment

File src/wasm/interpreter/wasm-interpreter-runtime.cc

Line 898, Patchset 7: if (module_->memories.empty() || module_->memories[0].!is_shared) {

Maksim Ivanov . unresolved

Gemini spotted a syntax error here (supposedly unnoticed since it's only for interpreter builds?).

Open in Gerrit

Related details

Attention is currently required from:

• Clemens Backes
• Leszek Swirski

Submit Requirements:

• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement
• SLSA-Policy-Verified

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Id703bdd17327b46177b74ffd633f3362a1c2b503

Gerrit-Change-Number: 8005975

Gerrit-PatchSet: 8

Gerrit-Owner: Clemens Backes <clem...@chromium.org>

Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>

Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>

Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>

Gerrit-CC: Hannes Payer <hpa...@chromium.org>

Gerrit-CC: Maksim Ivanov <em...@google.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: v8-s...@luci-project-accounts.iam.gserviceaccount.com <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Clemens Backes <clem...@chromium.org>

Gerrit-Attention: Leszek Swirski <les...@chromium.org>

Gerrit-Comment-Date: Wed, 01 Jul 2026 12:37:23 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Clemens Backes (Gerrit)]

Attention needed from Leszek Swirski and Maksim Ivanov

Clemens Backes added 1 comment

File src/wasm/interpreter/wasm-interpreter-runtime.cc

Line 898, Patchset 7: if (module_->memories.empty() || module_->memories[0].!is_shared) {

Maksim Ivanov . resolved

Gemini spotted a syntax error here (supposedly unnoticed since it's only for interpreter builds?).

Clemens Backes

Ah, yes, this is not compiled on our side. Fixed.

Open in Gerrit

Related details

Attention is currently required from:

• Leszek Swirski
• Maksim Ivanov

Submit Requirements:

• Code-Owners
• Code-Review

• Review-Enforcement
• SLSA-Policy-Verified

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Id703bdd17327b46177b74ffd633f3362a1c2b503

Gerrit-Change-Number: 8005975

Gerrit-PatchSet: 8

Gerrit-Owner: Clemens Backes <clem...@chromium.org>

Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>

Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>

Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>

Gerrit-CC: Hannes Payer <hpa...@chromium.org>

Gerrit-CC: Maksim Ivanov <em...@google.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: v8-s...@luci-project-accounts.iam.gserviceaccount.com <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Maksim Ivanov <em...@google.com>

Gerrit-Attention: Leszek Swirski <les...@chromium.org>

Gerrit-Comment-Date: Wed, 01 Jul 2026 12:44:22 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Maksim Ivanov <em...@google.com>

[Maksim Ivanov (Gerrit)]

Attention needed from Clemens Backes and Leszek Swirski

Maksim Ivanov added 4 comments

File src/compiler/turboshaft/wasm-wrappers-inl.h

Line 267, Patchset 9 (Latest): lazy_deopt_on_throw == compiler::LazyDeoptOnThrow{false});

Maksim Ivanov . unresolved

nit: Ditto here.

Line 201, Patchset 9 (Latest): DCHECK_IMPLIES(lazy_deopt_on_throw == compiler::LazyDeoptOnThrow{true},

Maksim Ivanov . unresolved

nit: Does it compile if we omit the "== ..." part entirely?

File src/wasm/interpreter/wasm-interpreter-runtime.cc

Line 2723, Patchset 9 (Latest): const bool type_is_shared = module_->types[type_index].is_shared;

Maksim Ivanov . resolved

There are also `v8_enable_drumbrake` build errors here and in 2750 where the implicit conversion is attempted. I'm not sure though if the CL is expected to take care of all that since it's externally-maintained.

File src/wasm/turboshaft-graph-interface.cc

Line 2771, Patchset 9 (Latest): DCHECK_EQ(shared_, SharedFlag{false});

Maksim Ivanov . unresolved

nit: Does it work to simply say `DCHECK(!shared_)`?

Ditto for other `DCHECK_EQ(shared_`, `DCHECK_EQ(table_type.is_shared()`.

Open in Gerrit

Related details

Attention is currently required from:

• Clemens Backes
• Leszek Swirski

Submit Requirements:

• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

• SLSA-Policy-Verified

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Id703bdd17327b46177b74ffd633f3362a1c2b503

Gerrit-Change-Number: 8005975

Gerrit-PatchSet: 9

Gerrit-Owner: Clemens Backes <clem...@chromium.org>

Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>

Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>

Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>

Gerrit-CC: Hannes Payer <hpa...@chromium.org>

Gerrit-CC: Maksim Ivanov <em...@google.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: v8-s...@luci-project-accounts.iam.gserviceaccount.com <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Clemens Backes <clem...@chromium.org>

Gerrit-Attention: Leszek Swirski <les...@chromium.org>

Gerrit-Comment-Date: Wed, 01 Jul 2026 13:10:33 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Clemens Backes (Gerrit)]

Attention needed from Leszek Swirski and Maksim Ivanov

Clemens Backes added 4 comments

File src/compiler/turboshaft/wasm-wrappers-inl.h

Line 267, Patchset 9: lazy_deopt_on_throw == compiler::LazyDeoptOnThrow{false});

Maksim Ivanov . resolved

nit: Ditto here.

Clemens Backes

Done

Line 201, Patchset 9: DCHECK_IMPLIES(lazy_deopt_on_throw == compiler::LazyDeoptOnThrow{true},

Maksim Ivanov . resolved

nit: Does it compile if we omit the "== ..." part entirely?

Clemens Backes

Sure, it does! Fixed.

File src/wasm/interpreter/wasm-interpreter-runtime.cc

Line 2723, Patchset 9: const bool type_is_shared = module_->types[type_index].is_shared;

Maksim Ivanov . resolved

There are also `v8_enable_drumbrake` build errors here and in 2750 where the implicit conversion is attempted. I'm not sure though if the CL is expected to take care of all that since it's externally-maintained.

Clemens Backes

We usually don't care about them. We could also opt to not touch the wasm interpreter directly at all. In this case though it's simple enough to ask gemini to just update that as well.

+Paolo FYI. Let me know if we should handle this differently.

File src/wasm/turboshaft-graph-interface.cc

Line 2771, Patchset 9: DCHECK_EQ(shared_, SharedFlag{false});

Maksim Ivanov . resolved

nit: Does it work to simply say `DCHECK(!shared_)`?

Ditto for other `DCHECK_EQ(shared_`, `DCHECK_EQ(table_type.is_shared()`.

Clemens Backes

Done

Open in Gerrit

Related details

Attention is currently required from:

• Leszek Swirski
• Maksim Ivanov

Submit Requirements:

• Code-Owners
• Code-Review

• Review-Enforcement
• SLSA-Policy-Verified

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Id703bdd17327b46177b74ffd633f3362a1c2b503

Gerrit-Change-Number: 8005975

Gerrit-PatchSet: 10

Gerrit-Owner: Clemens Backes <clem...@chromium.org>

Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>

Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>

Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>

Gerrit-CC: Hannes Payer <hpa...@chromium.org>

Gerrit-CC: Maksim Ivanov <em...@google.com>

Gerrit-CC: Paolo Severini <paol...@microsoft.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: v8-s...@luci-project-accounts.iam.gserviceaccount.com <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Maksim Ivanov <em...@google.com>

Gerrit-Attention: Leszek Swirski <les...@chromium.org>

Gerrit-Comment-Date: Wed, 01 Jul 2026 14:10:59 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Maksim Ivanov <em...@google.com>

[Maksim Ivanov (Gerrit)]

Attention needed from Clemens Backes and Leszek Swirski

Maksim Ivanov voted and added 1 comment

Votes added by Maksim Ivanov

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 10 (Latest):

Maksim Ivanov . resolved

thanks! lgtm

Open in Gerrit

Related details

Attention is currently required from:

• Clemens Backes
• Leszek Swirski

Submit Requirements:

• Code-Owners

• Code-Review
• Review-Enforcement
• SLSA-Policy-Verified

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Id703bdd17327b46177b74ffd633f3362a1c2b503

Gerrit-Change-Number: 8005975

Gerrit-PatchSet: 10

Gerrit-Owner: Clemens Backes <clem...@chromium.org>

Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>

Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>

Gerrit-Reviewer: Maksim Ivanov <em...@google.com>

Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>

Gerrit-CC: Hannes Payer <hpa...@chromium.org>

Gerrit-CC: Paolo Severini <paol...@microsoft.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: v8-s...@luci-project-accounts.iam.gserviceaccount.com <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Clemens Backes <clem...@chromium.org>

Gerrit-Attention: Leszek Swirski <les...@chromium.org>

Gerrit-Comment-Date: Wed, 01 Jul 2026 14:15:00 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Clemens Backes (Gerrit)]

Attention needed from Leszek Swirski

Clemens Backes added 1 comment

Patchset-level comments

File-level comment, Patchset 10 (Latest):

Maksim Ivanov . resolved

thanks! lgtm

Clemens Backes

Cool, thanks!

Leszek, can you provide ENG review?

Open in Gerrit

Related details

Attention is currently required from:

• Leszek Swirski

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement
• SLSA-Policy-Verified

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Id703bdd17327b46177b74ffd633f3362a1c2b503

Gerrit-Change-Number: 8005975

Gerrit-PatchSet: 10

Gerrit-Owner: Clemens Backes <clem...@chromium.org>

Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>

Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>

Gerrit-Reviewer: Maksim Ivanov <em...@google.com>

Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>

Gerrit-CC: Hannes Payer <hpa...@chromium.org>

Gerrit-CC: Paolo Severini <paol...@microsoft.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: v8-s...@luci-project-accounts.iam.gserviceaccount.com <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Leszek Swirski <les...@chromium.org>

Gerrit-Comment-Date: Wed, 01 Jul 2026 14:16:18 +0000

[Paolo Severini (Gerrit)]

Attention needed from Clemens Backes and Leszek Swirski

Paolo Severini added 1 comment

Patchset-level comments

File-level comment, Patchset 10 (Latest):

Paolo Severini . resolved

Thanks for the changes under wasm/interpreter/ !

Open in Gerrit

Related details

Attention is currently required from:

• Clemens Backes
• Leszek Swirski

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement
• SLSA-Policy-Verified

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Id703bdd17327b46177b74ffd633f3362a1c2b503

Gerrit-Change-Number: 8005975

Gerrit-PatchSet: 10

Gerrit-Owner: Clemens Backes <clem...@chromium.org>

Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>

Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>

Gerrit-Reviewer: Maksim Ivanov <em...@google.com>

Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>

Gerrit-CC: Hannes Payer <hpa...@chromium.org>

Gerrit-CC: Paolo Severini <paol...@microsoft.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: v8-s...@luci-project-accounts.iam.gserviceaccount.com <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Clemens Backes <clem...@chromium.org>

Gerrit-Attention: Leszek Swirski <les...@chromium.org>

Gerrit-Comment-Date: Wed, 01 Jul 2026 15:03:47 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Leszek Swirski (Gerrit)]

Attention needed from Clemens Backes

Leszek Swirski voted and added 1 comment

Votes added by Leszek Swirski

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 10 (Latest):

Leszek Swirski . resolved

overall lgtm

Open in Gerrit

Related details

Attention is currently required from:

• Clemens Backes

Submit Requirements:

• Code-Owners

• Code-Review
• Review-Enforcement
• SLSA-Policy-Verified

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Id703bdd17327b46177b74ffd633f3362a1c2b503

Gerrit-Change-Number: 8005975

Gerrit-PatchSet: 10

Gerrit-Owner: Clemens Backes <clem...@chromium.org>

Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>

Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>

Gerrit-Reviewer: Maksim Ivanov <em...@google.com>

Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>

Gerrit-CC: Hannes Payer <hpa...@chromium.org>

Gerrit-CC: Paolo Severini <paol...@microsoft.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: v8-s...@luci-project-accounts.iam.gserviceaccount.com <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Clemens Backes <clem...@chromium.org>

Gerrit-Comment-Date: Wed, 01 Jul 2026 15:34:20 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Clemens Backes (Gerrit)]

Clemens Backes voted and added 1 comment

Votes added by Clemens Backes

Commit-Queue

+2

1 comment

Patchset-level comments

File-level comment, Patchset 10 (Latest):

Clemens Backes . resolved

Nice, let's land this then before it needs another rebase!

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement
• SLSA-Policy-Verified

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Id703bdd17327b46177b74ffd633f3362a1c2b503

Gerrit-Change-Number: 8005975

Gerrit-PatchSet: 10

Gerrit-Owner: Clemens Backes <clem...@chromium.org>

Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>

Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>

Gerrit-Reviewer: Maksim Ivanov <em...@google.com>

Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>

Gerrit-CC: Hannes Payer <hpa...@chromium.org>

Gerrit-CC: Paolo Severini <paol...@microsoft.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: v8-s...@luci-project-accounts.iam.gserviceaccount.com <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Comment-Date: Wed, 01 Jul 2026 15:36:37 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)]

v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:

[wasm][common] Use StrongAlias for boolean-like enums

Migrate several boolean-like enums to base::StrongAlias<Tag, bool> to
improve type safety and align with the Blink C++ style guide. This
change replaces plain enums and "enum class : bool" with StrongAlias,
providing stronger typing while maintaining semantic clarity.

For most types, direct constructor calls (e.g., SharedFlag{true}) are
used at call sites to follow the style guide's recommendation for
explicit boolean-like StrongAlias usage. StrongAlias instances wrapping
bool are used directly in boolean expressions (e.g., if (flag)),
leveraging contextual conversion to bool.

Enums migrated to StrongAlias:
- SharedFlag, AllowAllocation, PerformHeapLimitCheck,
  PerformIneffectiveMarkCompactCheck, NeedsContext, AdaptArguments
- CanThrow, LazyDeoptOnThrow
- AlignmentCheck, EnforceBoundsCheck (fully migrated from enum class)
- CreateSourcePositions, CodeObjectRequired
- MarkAsIndirectJumpTarget
- ResizableFlag, ImmutableFlag
- Validation, EmptyNames, UpdateResult
- InitializedFlag, InSharedSpace

Newly introduced StrongAlias types:
- HasGuardRegions (for BackingStore/Wasm memory)
- CustomDeleter (for BackingStore)
- EmptyDeleter (for BackingStore)

Key Improvements and Cleanups:
- Used direct brace initialization (e.g., Type{true}) instead of named
  constants for MarkAsIndirectJumpTarget, AlignmentCheck, and
  InSharedSpace to leverage the expressiveness of the type names.
- Leveraged contextual boolean conversion for StrongAlias types to
  simplify checks (e.g., using 'if (flag)' instead of explicit equality
  comparisons with constants or literal values).
- Refactored the BackingStore constructor to replace five raw boolean
  parameters with type-safe StrongAlias and WasmMemoryFlag types,
  preventing accidental parameter swapping.
- Improved Turboshaft PrintOptions to use the custom operator<< for
  SharedFlag, ensuring consistent terminology in debug output.

Infrastructure support was added to base::StrongAlias for hashing and
Turboshaft integration (is_strong_alias_v).

TAG=agy
R=clem...@chromium.org
NO_IFTTT=renaming only

Change-Id: Id703bdd17327b46177b74ffd633f3362a1c2b503

Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8005975

Reviewed-by: Leszek Swirski <les...@chromium.org>

SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritco...@google.com>

Commit-Queue: Clemens Backes <clem...@chromium.org>

Reviewed-by: Maksim Ivanov <em...@google.com>

Cr-Commit-Position: refs/heads/main@{#108374}

Files:

• M docs/runtime/exception-handling.md
• M src/api/api.cc
• M src/base/strong-alias.h
• M src/baseline/baseline-compiler.cc
• M src/baseline/baseline-compiler.h
• M src/builtins/builtins-array-gen.cc
• M src/builtins/builtins-arraybuffer.cc
• M src/builtins/builtins-collections-gen.cc
• M src/builtins/builtins-constructor-gen.cc
• M src/builtins/builtins-definitions.h
• M src/builtins/builtins-generator-gen.cc
• M src/builtins/builtins-internal-gen.cc
• M src/builtins/builtins-intl-gen.cc
• M src/builtins/builtins-iterator-gen.cc
• M src/builtins/builtins-regexp-gen.cc
• M src/builtins/builtins-shadow-realm-gen.cc
• M src/builtins/builtins-string-gen.cc
• M src/builtins/builtins-typed-array.cc
• M src/builtins/number-builtins-reducer-inl.h
• M src/builtins/setup-builtins-internal.cc
• M src/codegen/assembler.h
• M src/codegen/code-stub-assembler-inl.h
• M src/codegen/code-stub-assembler.cc
• M src/codegen/code-stub-assembler.h
• M src/codegen/compiler.cc
• M src/codegen/compiler.h
• M src/codegen/interface-descriptors.h
• M src/codegen/macro-assembler-base.cc
• M src/codegen/turboshaft-builtins-assembler-inl.h
• M src/common/globals.h
• M src/compiler/backend/code-generator.cc
• M src/compiler/backend/instruction-selector.cc
• M src/compiler/globals.h
• M src/compiler/linkage.cc
• M src/compiler/linkage.h
• M src/compiler/turboshaft/assembler.h
• M src/compiler/turboshaft/assert-types-reducer.h
• M src/compiler/turboshaft/builtin-call-descriptors.h
• M src/compiler/turboshaft/fast-api-call-lowering-reducer.h
• M src/compiler/turboshaft/graph-builder.cc
• M src/compiler/turboshaft/growable-stacks-reducer.h
• M src/compiler/turboshaft/int64-lowering-reducer.h
• M src/compiler/turboshaft/machine-lowering-reducer-inl.h
• M src/compiler/turboshaft/memory-optimization-reducer.cc
• M src/compiler/turboshaft/operations.cc
• M src/compiler/turboshaft/operations.h
• M src/compiler/turboshaft/phase.h
• M src/compiler/turboshaft/runtime-call-descriptors.h
• M src/compiler/turboshaft/stack-check-lowering-reducer.h
• M src/compiler/turboshaft/turbolev-graph-builder.cc
• M src/compiler/turboshaft/wasm-gc-typed-optimization-reducer.h
• M src/compiler/turboshaft/wasm-in-js-inlining-reducer-inl.h
• M src/compiler/turboshaft/wasm-js-lowering-reducer.h
• M src/compiler/turboshaft/wasm-lowering-reducer.h
• M src/compiler/turboshaft/wasm-wrappers-inl.h
• M src/compiler/turboshaft/wasm-wrappers.cc
• M src/compiler/turboshaft/wasm-wrappers.h
• M src/compiler/wasm-compiler-definitions.h
• M src/compiler/wasm-compiler.h
• M src/compiler/wasm-inlining-into-js.cc
• M src/d8/d8.cc
• M src/debug/debug-scopes.cc
• M src/debug/debug.cc
• M src/debug/liveedit.cc
• M src/deoptimizer/translated-state.cc
• M src/diagnostics/unwinding-info-win64.cc
• M src/execution/frames.cc
• M src/execution/frames.h
• M src/execution/isolate.cc
• M src/execution/isolate.h
• M src/execution/messages.cc
• M src/heap/factory-base.cc
• M src/heap/factory-base.h
• M src/heap/factory.cc
• M src/heap/factory.h
• M src/heap/heap-allocator.cc
• M src/heap/heap.cc
• M src/heap/heap.h
• M src/heap/main-allocator.cc
• M src/heap/main-allocator.h
• M src/heap/read-only-spaces.cc
• M src/heap/setup-heap-internal.cc
• M src/ic/accessor-assembler.cc
• M src/interpreter/interpreter-generator-tsa.cc
• M src/maglev/maglev-assembler.h
• M src/objects/backing-store.cc
• M src/objects/backing-store.h
• M src/objects/bigint.cc
• M src/objects/fixed-array-inl.h
• M src/objects/fixed-array.h
• M src/objects/heap-object.h
• M src/objects/js-array-buffer.cc
• M src/objects/js-function.h
• M src/objects/js-objects.cc
• M src/objects/js-objects.h
• M src/objects/lookup.cc
• M src/objects/lookup.h
• M src/objects/managed-inl.h
• M src/objects/managed.cc
• M src/objects/managed.h
• M src/objects/objects-inl.h
• M src/objects/shared-function-info-inl.h
• M src/objects/shared-function-info.cc
• M src/objects/shared-function-info.h
• M src/objects/string.cc
• M src/objects/trusted-object-inl.h
• M src/objects/value-serializer.cc
• M src/parsing/func-name-inferrer.h
• M src/parsing/parser-base.h
• M src/parsing/parser.h
• M src/parsing/parsing.cc
• M src/parsing/parsing.h
• M src/parsing/preparser.h
• M src/regexp/arm/regexp-macro-assembler-arm.cc
• M src/regexp/arm64/regexp-macro-assembler-arm64.cc
• M src/regexp/ia32/regexp-macro-assembler-ia32.cc
• M src/regexp/loong64/regexp-macro-assembler-loong64.cc
• M src/regexp/mips64/regexp-macro-assembler-mips64.cc
• M src/regexp/ppc/regexp-macro-assembler-ppc.cc
• M src/regexp/riscv/regexp-macro-assembler-riscv.cc
• M src/regexp/s390/regexp-macro-assembler-s390.cc
• M src/regexp/x64/regexp-macro-assembler-x64.cc
• M src/runtime/runtime-test-wasm.cc
• M src/runtime/runtime-test.cc
• M src/runtime/runtime-wasm.cc
• M src/sandbox/indirect-pointer-tag.h
• M src/sandbox/testing.cc
• M src/snapshot/deserializer.cc
• M src/wasm/baseline/liftoff-assembler.cc
• M src/wasm/baseline/liftoff-compiler.cc
• M src/wasm/baseline/loong64/liftoff-assembler-loong64-inl.h
• M src/wasm/baseline/mips64/liftoff-assembler-mips64-inl.h
• M src/wasm/baseline/riscv/liftoff-assembler-riscv-inl.h
• M src/wasm/c-api.cc
• M src/wasm/canonical-types.cc
• M src/wasm/canonical-types.h
• M src/wasm/constant-expression-interface.cc
• M src/wasm/constant-expression.cc
• M src/wasm/function-body-decoder-impl.h
• M src/wasm/function-body-decoder.cc
• M src/wasm/function-compiler.cc
• M src/wasm/function-compiler.h
• M src/wasm/fuzzing/random-module-generation.cc
• M src/wasm/interpreter/wasm-interpreter-runtime.cc
• M src/wasm/interpreter/wasm-interpreter-runtime.h
• M src/wasm/interpreter/wasm-interpreter.cc
• M src/wasm/module-compiler.cc
• M src/wasm/module-decoder-impl.h
• M src/wasm/module-decoder.cc
• M src/wasm/module-instantiate.cc
• M src/wasm/struct-types.h
• M src/wasm/turboshaft-graph-interface-inl.h
• M src/wasm/turboshaft-graph-interface.cc
• M src/wasm/turboshaft-graph-interface.h
• M src/wasm/value-type.cc
• M src/wasm/value-type.h
• M src/wasm/wasm-code-manager.cc
• M src/wasm/wasm-disassembler.cc
• M src/wasm/wasm-js.cc
• M src/wasm/wasm-module-builder.cc
• M src/wasm/wasm-module.cc
• M src/wasm/wasm-module.h
• M src/wasm/wasm-objects.cc
• M src/wasm/wasm-objects.h
• M src/wasm/well-known-imports.cc
• M src/wasm/well-known-imports.h
• M test/cctest/heap/test-concurrent-allocation.cc
• M test/cctest/heap/test-heap.cc
• M test/cctest/heap/test-spaces.cc
• M test/cctest/test-code-stub-assembler.cc
• M test/cctest/test-icache.cc
• M test/cctest/test-sync-primitives-arm64.cc
• M test/cctest/wasm/test-backing-store.cc
• M test/cctest/wasm/test-gc.cc
• M test/cctest/wasm/test-grow-memory.cc
• M test/cctest/wasm/test-jump-table-assembler.cc
• M test/cctest/wasm/test-run-wasm-memory64.cc
• M test/cctest/wasm/test-run-wasm.cc
• M test/common/wasm/fuzzer-common.cc
• M test/common/wasm/wasm-run-utils.cc
• M test/common/wasm/wasm-run-utils.h
• M test/filecheck/js-wasm-wrapper-inlining-type-combos.js
• M test/filecheck/wasm-in-js-inlining-turboshaft.js
• M test/fuzzer/parser.cc
• M test/fuzzer/wasm/interpreter/interpreter-fuzzer-common.cc
• M test/mjsunit/regress/wasm/regress-498709150.js
• M test/mjsunit/wasm/shared-everything/atomic-instructions.js
• M test/unittests/assembler/assembler-arm-unittest.cc
• M test/unittests/assembler/assembler-arm64-unittest.cc
• M test/unittests/assembler/assembler-helper-arm.cc
• M test/unittests/assembler/assembler-ia32-unittest.cc
• M test/unittests/assembler/assembler-loong64-unittest.cc
• M test/unittests/assembler/assembler-mips64-unittest.cc
• M test/unittests/assembler/assembler-riscv32-unittest.cc
• M test/unittests/assembler/assembler-riscv64-unittest.cc
• M test/unittests/assembler/assembler-x64-unittest.cc
• M test/unittests/assembler/disasm-arm64-unittest.cc
• M test/unittests/assembler/macro-assembler-arm-unittest.cc
• M test/unittests/assembler/macro-assembler-arm64-unittest.cc
• M test/unittests/assembler/macro-assembler-ia32-unittest.cc
• M test/unittests/assembler/macro-assembler-loong64-unittest.cc
• M test/unittests/assembler/macro-assembler-mips64-unittest.cc
• M test/unittests/assembler/macro-assembler-ppc-unittest.cc
• M test/unittests/assembler/macro-assembler-riscv32-unittest.cc
• M test/unittests/assembler/macro-assembler-riscv64-unittest.cc
• M test/unittests/assembler/macro-assembler-s390-unittest.cc
• M test/unittests/assembler/macro-assembler-x64-unittest.cc
• M test/unittests/assembler/simple-riscv32-unittest.cc
• M test/unittests/assembler/simple-riscv64-unittest.cc
• M test/unittests/assembler/test-helper-riscv32.cc
• M test/unittests/assembler/test-helper-riscv32.h
• M test/unittests/assembler/test-helper-riscv64.cc
• M test/unittests/assembler/test-helper-riscv64.h
• M test/unittests/compiler/backend/turboshaft-instruction-selector-unittest.h
• M test/unittests/objects/managed-unittest.cc
• M test/unittests/objects/value-serializer-unittest.cc
• M test/unittests/objects/wasm-backing-store-unittest.cc
• M test/unittests/parser/parsing-unittest.cc
• M test/unittests/parser/preparser-unittest.cc
• M test/unittests/wasm/compilation-hints-unittest.cc
• M test/unittests/wasm/function-body-decoder-unittest.cc
• M test/unittests/wasm/module-decoder-unittest.cc
• M test/unittests/wasm/struct-types-unittest.cc
• M test/unittests/wasm/subtyping-unittest.cc
• M test/unittests/wasm/trap-handler-native-unittest.cc
• M test/unittests/wasm/trap-handler-simulator-unittest.cc
• M test/unittests/wasm/type-canonicalization-fuzztest.cc
• M test/unittests/wasm/wasm-tracing-unittest.cc
• M tools/gcmole/test-expectations.txt
• M tools/wasm/mjsunit-module-disassembler-impl.h
• M tools/wasm/module-inspector.cc

Change size: XL

Delta: 231 files changed, 1922 insertions(+), 1967 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Maksim Ivanov, +1 by Leszek Swirski
• SLSA-Policy-Verified: +1 by SLSA Policy Verification Service

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Id703bdd17327b46177b74ffd633f3362a1c2b503

Gerrit-Change-Number: 8005975

Gerrit-PatchSet: 11

Gerrit-Owner: Clemens Backes <clem...@chromium.org>

Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>

Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>

Gerrit-Reviewer: Maksim Ivanov <em...@google.com>

Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>

Gerrit-Reviewer: v8-s...@luci-project-accounts.iam.gserviceaccount.com <v8-s...@luci-project-accounts.iam.gserviceaccount.com>