[for-of-performance] Only check value if done is false [v8/v8 : main]
0 views
Skip to first unread message
Rezvan Mahdavi Hezaveh (Gerrit)
Feb 20, 2026, 7:31:17 PM (4 days ago) Feb 20
to Marja Hölttä, Leszek Swirski, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Marja Hölttä
Rezvan Mahdavi Hezaveh added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Rezvan Mahdavi Hezaveh . resolved
Marja, as you suggested in a comment on my other CL (https://chromium-review.googlesource.com/c/v8/v8/+/7261252), I split this fix to a new CL and added the tests. Please take a look, thanks!
Related details
Attention is currently required from:
- Marja Hölttä
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marja Hölttä (Gerrit)
Feb 23, 2026, 3:34:18 AM (yesterday) Feb 23
to Rezvan Mahdavi Hezaveh, Leszek Swirski, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Rezvan Mahdavi Hezaveh
Marja Hölttä voted and added 3 comments![]( "Open in Gerrit")
Votes added by Marja Hölttä
| Code-Review | +1 |
3 comments
Patchset-level comments
Marja Hölttä . resolved
lgtm, thanks!
File test/mjsunit/es6/for-of-iterator-protocol-integrity.js
Line 54, Patchset 3 (Latest):
for (const x of iterable) { /* NOP */ }Marja Hölttä . unresolved
Nit: this test could still assert that the loop body runs the correct amount of times (here: 0)
Line 82, Patchset 3 (Latest):
for (const x of iterable) { /* x triggers the getter */ }Marja Hölttä . unresolved
ditto
Related details
Attention is currently required from:
- Rezvan Mahdavi Hezaveh
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rezvan Mahdavi Hezaveh (Gerrit)
Feb 23, 2026, 1:37:14 PM (19 hours ago) Feb 23
to Marja Hölttä, Leszek Swirski, V8 LUCI CQ, v8-re...@googlegroups.com
Rezvan Mahdavi Hezaveh added 2 comments![]( "Open in Gerrit")
File test/mjsunit/es6/for-of-iterator-protocol-integrity.js
Nit: this test could still assert that the loop body runs the correct amount of times (here: 0)
Rezvan Mahdavi Hezaveh
Done
Line 82, Patchset 3:
for (const x of iterable) { /* x triggers the getter */ }Marja Hölttä . resolved
Rezvan Mahdavi Hezavehditto
Done
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rezvan Mahdavi Hezaveh (Gerrit)
Feb 23, 2026, 1:38:05 PM (19 hours ago) Feb 23
to Leszek Swirski, Marja Hölttä, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Leszek Swirski
Rezvan Mahdavi Hezaveh added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Rezvan Mahdavi Hezaveh . resolved
Leszek, I need your review as an owner of code-stub-assembler. PTAL, thanks!
Related details
Attention is currently required from:
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
3:11 AM (6 hours ago) 3:11 AM
to Rezvan Mahdavi Hezaveh, Marja Hölttä, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Rezvan Mahdavi Hezaveh
Leszek Swirski voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Rezvan Mahdavi Hezaveh
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages