[defer-import-eval] Record stack overflow from module evaluation [v8/v8 : main]

[Olivier Flückiger (Gerrit)]

Attention needed from Caio Lima and Marja Hölttä

Olivier Flückiger added 1 comment

File test/mjsunit/harmony/modules-import-defer-stack-overflow-on-sync-eval.mjs

Line 22, Patchset 4 (Latest): Object.defineProperty(ns, 'x', { value: 1 });

Olivier Flückiger . unresolved

I am confused by this test. isn't line 22 never reached, because we already range error at line 21?

Open in Gerrit

Related details

Attention is currently required from:

• Caio Lima
• Marja Hölttä

Submit Requirements:

• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I9c8dd9c3e3e6cde6416d7f86de949d58e1b43680

Gerrit-Change-Number: 8026189

Gerrit-PatchSet: 4

Gerrit-Owner: Caio Lima <caio...@igalia.com>

Gerrit-Reviewer: Caio Lima <caio...@igalia.com>

Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>

Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>

Gerrit-CC: v8-s...@luci-project-accounts.iam.gserviceaccount.com <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Caio Lima <caio...@igalia.com>

Gerrit-Attention: Marja Hölttä <ma...@chromium.org>

Gerrit-Comment-Date: Wed, 01 Jul 2026 11:29:32 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Caio Lima (Gerrit)]

Attention needed from Marja Hölttä and Olivier Flückiger

Caio Lima added 1 comment

File test/mjsunit/harmony/modules-import-defer-stack-overflow-on-sync-eval.mjs

Line 22, Patchset 4 (Latest): Object.defineProperty(ns, 'x', { value: 1 });

Olivier Flückiger . unresolved

I am confused by this test. isn't line 22 never reached, because we already range error at line 21?

Caio Lima

Oops, you are right. I need to add a try-catch on `recurse` that's missing. Let me update it.

Open in Gerrit

Related details

Attention is currently required from:

• Marja Hölttä
• Olivier Flückiger

Submit Requirements:

• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I9c8dd9c3e3e6cde6416d7f86de949d58e1b43680

Gerrit-Change-Number: 8026189

Gerrit-PatchSet: 4

Gerrit-Owner: Caio Lima <caio...@igalia.com>

Gerrit-Reviewer: Caio Lima <caio...@igalia.com>

Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>

Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>

Gerrit-CC: v8-s...@luci-project-accounts.iam.gserviceaccount.com <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Olivier Flückiger <ol...@chromium.org>

Gerrit-Attention: Marja Hölttä <ma...@chromium.org>

Gerrit-Comment-Date: Wed, 01 Jul 2026 11:40:50 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Olivier Flückiger <ol...@chromium.org>

[Olivier Flückiger (Gerrit)]

Attention needed from Caio Lima and Marja Hölttä

Olivier Flückiger voted and added 1 comment

Votes added by Olivier Flückiger

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Olivier Flückiger . resolved

lgtm, thanks

Open in Gerrit

Related details

Attention is currently required from:

• Caio Lima
• Marja Hölttä

Submit Requirements:

• Code-Owners

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I9c8dd9c3e3e6cde6416d7f86de949d58e1b43680

Gerrit-Change-Number: 8026189

Gerrit-PatchSet: 5

Gerrit-Owner: Caio Lima <caio...@igalia.com>

Gerrit-Reviewer: Caio Lima <caio...@igalia.com>

Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>

Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>

Gerrit-CC: v8-s...@luci-project-accounts.iam.gserviceaccount.com <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Caio Lima <caio...@igalia.com>

Gerrit-Attention: Marja Hölttä <ma...@chromium.org>

Gerrit-Comment-Date: Wed, 01 Jul 2026 13:52:02 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Caio Lima (Gerrit)]

Attention needed from Marja Hölttä

Caio Lima added 1 comment

File test/mjsunit/harmony/modules-import-defer-stack-overflow-on-sync-eval.mjs

Line 22, Patchset 4: Object.defineProperty(ns, 'x', { value: 1 });

Olivier Flückiger . resolved

I am confused by this test. isn't line 22 never reached, because we already range error at line 21?

Caio Lima

Oops, you are right. I need to add a try-catch on `recurse` that's missing. Let me update it.

Caio Lima

Done

Open in Gerrit

Related details

Attention is currently required from:

• Marja Hölttä

Submit Requirements:

• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I9c8dd9c3e3e6cde6416d7f86de949d58e1b43680

Gerrit-Change-Number: 8026189

Gerrit-PatchSet: 5

Gerrit-Owner: Caio Lima <caio...@igalia.com>

Gerrit-Reviewer: Caio Lima <caio...@igalia.com>

Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>

Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>

Gerrit-CC: v8-s...@luci-project-accounts.iam.gserviceaccount.com <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Marja Hölttä <ma...@chromium.org>

Gerrit-Comment-Date: Wed, 01 Jul 2026 14:58:12 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Caio Lima <caio...@igalia.com>

Comment-In-Reply-To: Olivier Flückiger <ol...@chromium.org>