[maps] Support customizable map shapes [v8/v8 : main]
Igor Sheludko (Gerrit)
Igor Sheludko voted and added 2 comments![]( "Open in Gerrit")
Votes added by Igor Sheludko
| Commit-Queue | +1 |
2 comments
PTAL, I went with option 2.1 from the doc (option 2.2 had some complications that I missed initially).
WriteBarrier::ForRange(isolate->heap(), raw, slot, slot + count);I didn't manage to make `cctest/test-heap/JSInterceptorMap` crash without this WB even with `--stress-compaction`, are there any other flags to try?
Related details
- Leszek Swirski
- Michael Lippautz
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Michael Lippautz added 7 comments![]( "Open in Gerrit")
constexpr const char* ExtendedMapKind2String(ExtendedMapKind kind) {...ToString
}For sandbox: default: UNREACHABLE()
(I know it's a bit annoying)
switch (map_ex->map_kind()) {Same here: sandbox swich valiation
uint8_t padding1_;
uint16_t padding2_;Can we create a padding helper that uses packed structs?
E.g., would be nice to have an `AlignedUpToTaggedForExtendedMap dummy;` here.
WriteBarrier::ForRange(isolate->heap(), raw, slot, slot + count);I didn't manage to make `cctest/test-heap/JSInterceptorMap` crash without this WB even with `--stress-compaction`, are there any other flags to try?
`--stress-compaction` and maybe `--stress-incremental-marking` would be the flags to use here.
Related details
- Igor Sheludko
- Leszek Swirski
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Igor Sheludko (Gerrit)
Igor Sheludko voted and added 7 comments![]( "Open in Gerrit")
Votes added by Igor Sheludko
| Commit-Queue | +1 |
7 comments
constexpr const char* ExtendedMapKind2String(ExtendedMapKind kind) {Igor Sheludko...ToString
Done
For sandbox: default: UNREACHABLE()
(I know it's a bit annoying)
Done but slightly differently. I didn't use `default:` in order to enforce updating this switch then new kinds appear.
Same here: sandbox swich valiation
It's better to leave it this way since it's annoying when printer crashes during debugging session of a sandbox issue. We'll see that it's broken from the `- extended map kind: <corrupt>` line.
if (is_extended_map()) {Igor Sheludko[[unlikely]]
Done
Can we create a padding helper that uses packed structs?
E.g., would be nice to have an `AlignedUpToTaggedForExtendedMap dummy;` here.
I added support to Torque to generate fixed-size arrays in the middle of the object body. It seems to be the next simplest thing we can do.
WriteBarrier::ForRange(isolate->heap(), raw, slot, slot + count);Michael LippautzI didn't manage to make `cctest/test-heap/JSInterceptorMap` crash without this WB even with `--stress-compaction`, are there any other flags to try?
`--stress-compaction` and maybe `--stress-incremental-marking` would be the flags to use here.
- Leszek Swirski
- Michael Lippautz
- Nico Hartmann
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Hartmann (Gerrit)
Nico Hartmann added 1 comment![]( "Open in Gerrit")
- Igor Sheludko
- Leszek Swirski
- Michael Lippautz
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Hartmann (Gerrit)
Nico Hartmann voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
- Igor Sheludko
- Leszek Swirski
- Michael Lippautz
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Igor Sheludko (Gerrit)
Igor Sheludko voted and added 1 comment![]( "Open in Gerrit")
Votes added by Igor Sheludko
| Commit-Queue | +1 |
1 comment
I've lost Nico's +1 because required changes in src/torque/implementation-visitor.cc were landed inbetween (https://crrev.com/c/7800234).
Related details
- Leszek Swirski
- Michael Lippautz
- Nico Hartmann
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |