[heap] Simplify ResourceConstraints::ConfigureDefaults [v8/v8 : main]
0 views
Skip to first unread message
Etienne Pierre-Doray (Gerrit)
Oct 23, 2025, 3:50:57 PM (2 days ago) Oct 23
to Dominik Inführ, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ
Etienne Pierre-Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
Oct 24, 2025, 2:33:29 AM (2 days ago) Oct 24
to Etienne Pierre-Doray, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Etienne Pierre-Doray
Dominik Inführ voted and added 2 comments![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Code-Review | +1 |
2 comments
Patchset-level comments
Dominik Inführ . resolved
Thanks, LGTM
File src/heap/heap.cc
Line 347, Patchset 3 (Latest):
size_t Heap::OldGenerationSizeFromPhysicalMemory(uint64_t physical_memory) {Dominik Inführ . unresolved
Nit: MaxOldGenerationSizeFromPhysicalMemory?
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
Oct 24, 2025, 2:42:28 AM (2 days ago) Oct 24
to Etienne Pierre-Doray, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Etienne Pierre-Doray
Dominik Inführ added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Dominik Inführ . resolved
Very nice, thanks a lot!
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
Oct 24, 2025, 2:48:24 AM (2 days ago) Oct 24
to Etienne Pierre-Doray, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Etienne Pierre-Doray
Dominik Inführ added 1 comment![]( "Open in Gerrit")
File src/heap/heap.cc
Line 347, Patchset 3 (Latest):
size_t Heap::OldGenerationSizeFromPhysicalMemory(uint64_t physical_memory) {Dominik Inführ . resolved
Dominik InführNit: MaxOldGenerationSizeFromPhysicalMemory?
Ah sorry, I understand now why this is like this.
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Oct 24, 2025, 7:37:43 AM (2 days ago) Oct 24
to Michael Lippautz, Dominik Inführ, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Etienne Pierre-Doray . resolved
Rebased on ToT now
+mlippautz@ for src/api/
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Oct 24, 2025, 7:38:45 AM (2 days ago) Oct 24
to Etienne Pierre-Doray, Dominik Inführ, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Etienne Pierre-Doray
Michael Lippautz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Oct 24, 2025, 8:02:05 AM (2 days ago) Oct 24
to Michael Lippautz, Dominik Inführ, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Etienne Pierre-Doray voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Oct 24, 2025, 8:03:46 AM (2 days ago) Oct 24
to Etienne Pierre-Doray, Michael Lippautz, Dominik Inführ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[heap] Simplify ResourceConstraints::ConfigureDefaults
This CL avoids the extra hoop of computing old/yound size from heap size
and queries these directly in ResourceConstraints::ConfigureDefaults.
Bug: chromium:454097973
Change-Id: I704616f340f9515b0eecfde3d1775addd1e4e796
Reviewed-by: Dominik Inführ <dinf...@chromium.org>
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103338}
Files:
- M src/api/api.cc
- M src/heap/heap.cc
- M src/heap/heap.h
- M test/cctest/test-code-stub-assembler.cc
- M test/unittests/heap/heap-unittest.cc
Change size: M
Delta: 5 files changed, 31 insertions(+), 36 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz, +1 by Dominik Inführ
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages