[flags] explicitly capture-default for kFlagNames [v8/v8 : main]
0 views
Skip to first unread message
Leszek Swirski (Gerrit)
4:14 AM (19 hours ago) 4:14 AM
to Michaël Zasso, Jakob Linke, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Jakob Linke and Michaël Zasso
Leszek Swirski voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Jakob Linke
- Michaël Zasso
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Linke (Gerrit)
5:17 AM (18 hours ago) 5:17 AM
to Michaël Zasso, Leszek Swirski, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Michaël Zasso
Jakob Linke voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Michaël Zasso
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michaël Zasso (Gerrit)
5:21 AM (18 hours ago) 5:21 AM
to Jakob Linke, Leszek Swirski, V8 LUCI CQ, v8-re...@googlegroups.com
Michaël Zasso voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
5:23 AM (18 hours ago) 5:23 AM
to Michaël Zasso, Jakob Linke, Leszek Swirski, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[flags] explicitly capture-default for kFlagNames
Should fix the following error in Node.js builds:
../../deps/v8/src/flags/flags.cc: In lambda function:
../../deps/v8/src/flags/flags.cc:324:38: error: 'kFlagNames' is not captured
324 | return FlagHelpers::FlagNamesCmp(kFlagNames[i], kFlagNames[j]) < 0;
| ^~~~~~~~~~
../../deps/v8/src/flags/flags.cc:323:46: note: the lambda has no capture-default
323 | std::sort(indices.begin(), indices.end(), [](int i, int j) {
| ^
../../deps/v8/src/flags/flags.cc:309:25: note: 'constexpr const char* const kFlagNames [942]' declared here
309 | constexpr const char* kFlagNames[] = {
| ^~~~~~~~~~
../../deps/v8/src/flags/flags.cc:324:53: error: 'kFlagNames' is not captured
324 | return FlagHelpers::FlagNamesCmp(kFlagNames[i], kFlagNames[j]) < 0;
| ^~~~~~~~~~
../../deps/v8/src/flags/flags.cc:323:46: note: the lambda has no capture-default
323 | std::sort(indices.begin(), indices.end(), [](int i, int j) {
| ^
../../deps/v8/src/flags/flags.cc:309:25: note: 'constexpr const char* const kFlagNames [942]' declared here
309 | constexpr const char* kFlagNames[] = {
| ^~~~~~~~~~
Change-Id: I7ec81b4c1ebf7bc7db00a834e7d089d81ded8f1b
Reviewed-by: Leszek Swirski <les...@chromium.org>
Commit-Queue: Michaël Zasso <mic.b...@gmail.com>
Reviewed-by: Jakob Linke <jgr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104590}
Files:
- M src/flags/flags.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jakob Linke, +1 by Leszek Swirski
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages