[math-sum-precise] Cleanup and faster iteration [v8/v8 : main]
0 views
Skip to first unread message
Olivier Flückiger (Gerrit)
Feb 3, 2026, 4:32:11 AM (24 hours ago) Feb 3
to Nikolaos Papaspyrou, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Nikolaos Papaspyrou
Olivier Flückiger voted and added 1 comment![]( "Open in Gerrit")
Votes added by Olivier Flückiger
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Nikolaos Papaspyrou
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nikolaos Papaspyrou (Gerrit)
Feb 3, 2026, 6:18:28 AM (22 hours ago) Feb 3
to Olivier Flückiger, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Olivier Flückiger
Nikolaos Papaspyrou voted and added 3 comments![]( "Open in Gerrit")
Votes added by Nikolaos Papaspyrou
| Code-Review | +1 |
3 comments
Patchset-level comments
File-level comment, Patchset 18 (Latest):
Nikolaos Papaspyrou . resolved
LGTM, thanks Olivier!
Just a couple of nits.
File src/builtins/builtins-math-xsum.h
File src/builtins/builtins-math.cc
Line 59, Patchset 18 (Latest):
auto res = xsum.GetSumPrecise();
switch (std::get<Xsum::Result>(res)) {Nikolaos Papaspyrou . unresolved
Nit:
```suggestion
switch (auto res = xsum.GetSumPrecise(); std::get<Xsum::Result>(res)) {
```
Related details
Attention is currently required from:
- Olivier Flückiger
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olivier Flückiger (Gerrit)
Feb 3, 2026, 6:53:09 AM (21 hours ago) Feb 3
to Nikolaos Papaspyrou, V8 LUCI CQ, v8-re...@googlegroups.com
Olivier Flückiger voted and added 3 comments![]( "Open in Gerrit")
Votes added by Olivier Flückiger
| Auto-Submit | +1 |
| Commit-Queue | +2 |
3 comments
Patchset-level comments
File src/builtins/builtins-math-xsum.h
File src/builtins/builtins-math.cc
Line 59, Patchset 18:
auto res = xsum.GetSumPrecise();
switch (std::get<Xsum::Result>(res)) {Nikolaos Papaspyrou . resolved
Nit:
```suggestion
switch (auto res = xsum.GetSumPrecise(); std::get<Xsum::Result>(res)) {
```
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Feb 3, 2026, 8:55:25 AM (19 hours ago) Feb 3
to Olivier Flückiger, Nikolaos Papaspyrou, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
18 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: src/builtins/builtins-math-xsum.h
Insertions: 1, Deletions: 0.
@@ -51,6 +51,7 @@
kMinusInfinity,
kNaN
};
+
inline std::tuple<Result, double> GetSumPrecise() {
if (minus_zero_) {
return {Result::kMinusZero, 0};
```
```
The name of the file: src/builtins/builtins-math.cc
Insertions: 1, Deletions: 2.
@@ -56,8 +56,7 @@
return ReadOnlyRoots(isolate).exception();
}
- auto res = xsum.GetSumPrecise();
- switch (std::get<Xsum::Result>(res)) {
+ switch (auto res = xsum.GetSumPrecise(); std::get<Xsum::Result>(res)) {
case Xsum::Result::kMinusZero:
return ReadOnlyRoots(isolate).minus_zero_value();
case Xsum::Result::kPlusInfinity:
```
Change information
Commit message:
[math-sum-precise] Cleanup and faster iteration
* Merge SumPreciseState and Xsum since they are partially tracking the
same thing (+35%).
* Templates for splitting on double/int type addition operands (+30%).
Bug: 374310075
Change-Id: Id729b7184863dd197404499bd9617e06b0b7c3d0
Auto-Submit: Olivier Flückiger <ol...@chromium.org>
Commit-Queue: Olivier Flückiger <ol...@chromium.org>
Reviewed-by: Nikolaos Papaspyrou <niko...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105057}
Files:
- M src/builtins/builtins-math-xsum.cc
- M src/builtins/builtins-math-xsum.h
- M src/builtins/builtins-math.cc
Change size: L
Delta: 3 files changed, 110 insertions(+), 149 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nikolaos Papaspyrou
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages