[sandbox] Expose Memory Corruption API on sandbox bots [v8/v8 : main]

Samuel Groß (Gerrit)

unread,

May 20, 2022, 7:35:11 AM5/20/22

to Michael Achenbach, V8 LUCI CQ, v8-re...@googlegroups.com

Attention is currently required from: Michael Achenbach.

Patch set 2:Auto-Submit +1

View Change

To view, visit change 3657427. To unsubscribe, or for help writing mail filters, visit settings.

Michael Achenbach (Gerrit)

unread,

May 20, 2022, 7:50:52 AM5/20/22

to Samuel Groß, V8 LUCI CQ, v8-re...@googlegroups.com

Attention is currently required from: Samuel Groß.

Patch set 2:Code-Review +1Commit-Queue +2

View Change

To view, visit change 3657427. To unsubscribe, or for help writing mail filters, visit settings.

V8 LUCI CQ (Gerrit)

unread,

May 20, 2022, 8:20:57 AM5/20/22

to Samuel Groß, Michael Achenbach, v8-re...@googlegroups.com

V8 LUCI CQ submitted this change.

View Change

Approvals:
  Samuel Groß: Send CL to CQ automatically after approval; Dry run
  Michael Achenbach: Looks good to me; Commit

[sandbox] Expose Memory Corruption API on sandbox bots

These bots should run sandbox tests in the future, for which the memory
corruption API will be required.

Bug: v8:12878
Change-Id: Ib64bfb0ae080016db6d1629f375d2a71a20d70b4
Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3657427
Reviewed-by: Michael Achenbach <mache...@chromium.org>
Commit-Queue: Michael Achenbach <mache...@chromium.org>
Commit-Queue: Samuel Groß <sa...@chromium.org>
Auto-Submit: Samuel Groß <sa...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80665}
---
M infra/mb/mb_config.pyl
1 file changed, 26 insertions(+), 2 deletions(-)

diff --git a/infra/mb/mb_config.pyl b/infra/mb/mb_config.pyl
index 2082517..ebb1e1f 100644
--- a/infra/mb/mb_config.pyl
+++ b/infra/mb/mb_config.pyl
@@ -578,9 +578,9 @@
     'debug_x64_header_includes': [
       'debug_bot', 'x64', 'v8_check_header_includes'],
     'debug_x64_heap_sandbox': [
-      'debug_bot', 'x64', 'v8_enable_sandbox_future'],
+      'debug_bot', 'x64', 'v8_enable_sandbox_future', 'v8_expose_memory_corruption_api'],
     'debug_x64_heap_sandbox_arm64_sim': [
-      'debug_bot', 'simulate_arm64', 'v8_enable_sandbox_future'],
+      'debug_bot', 'simulate_arm64', 'v8_enable_sandbox_future', 'v8_expose_memory_corruption_api'],
     'debug_x64_minimal_symbols': [
       'debug_bot', 'x64', 'minimal_symbols'],
     'debug_x64_non_default_cppgc': [
@@ -927,6 +927,10 @@
       'gn_args': 'v8_enable_sandbox_future=true',
     },
 
+    'v8_expose_memory_corruption_api': {
+      'gn_args': 'v8_expose_memory_corruption_api=true',
+    },
+
     'v8_enable_lite_mode': {
       'gn_args': 'v8_enable_lite_mode=true',
     },

To view, visit change 3657427. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward