[wasm interpreter] Direct CallRef when the wasm instance is same. [v8/v8 : main]

0 views
Skip to first unread message

Clemens Backes (Gerrit)

unread,
Dec 10, 2025, 2:37:51 PM (6 days ago) Dec 10
to 王忠齐, Paolo Severini, AyeAye, v8-re...@googlegroups.com, was...@google.com
Attention needed from Paolo Severini and 王忠齐

Clemens Backes voted and added 1 comment

Votes added by Clemens Backes

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Clemens Backes . resolved

Rubber-stamp as this only affects the interpreter. Paolo will do an actual review.

Open in Gerrit

Related details

Attention is currently required from:
  • Paolo Severini
  • 王忠齐
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I347bb8b97c79f3414d25eba393d1ded24afc28c1
Gerrit-Change-Number: 7247407
Gerrit-PatchSet: 1
Gerrit-Owner: 王忠齐 <wzq225...@gmail.com>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Paolo Severini <paol...@microsoft.com>
Gerrit-Attention: Paolo Severini <paol...@microsoft.com>
Gerrit-Attention: 王忠齐 <wzq225...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Dec 2025 19:37:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Paolo Severini (Gerrit)

unread,
Dec 15, 2025, 10:42:06 AM (22 hours ago) Dec 15
to 王忠齐, Clemens Backes, AyeAye, v8-re...@googlegroups.com, was...@google.com
Attention needed from 王忠齐

Paolo Severini voted and added 1 comment

Votes added by Paolo Severini

Code-Review+1

1 comment

File src/wasm/interpreter/wasm-interpreter-runtime.cc
Line 1932, Patchset 1 (Latest): if (IsWasmTrustedInstanceData(*object_implicit_arg)) {
Paolo Severini . unresolved

The first `if` should be redundant.

Open in Gerrit

Related details

Attention is currently required from:
  • 王忠齐
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I347bb8b97c79f3414d25eba393d1ded24afc28c1
Gerrit-Change-Number: 7247407
Gerrit-PatchSet: 1
Gerrit-Owner: 王忠齐 <wzq225...@gmail.com>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Paolo Severini <paol...@microsoft.com>
Gerrit-Attention: 王忠齐 <wzq225...@gmail.com>
Gerrit-Comment-Date: Mon, 15 Dec 2025 15:42:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Paolo Severini (Gerrit)

unread,
Dec 15, 2025, 10:42:28 AM (22 hours ago) Dec 15
to 王忠齐, Clemens Backes, AyeAye, v8-re...@googlegroups.com, was...@google.com
Attention needed from 王忠齐

Paolo Severini added 1 comment

Patchset-level comments
Paolo Severini . resolved

LGTM, with a comment.

Open in Gerrit

Related details

Attention is currently required from:
  • 王忠齐
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I347bb8b97c79f3414d25eba393d1ded24afc28c1
Gerrit-Change-Number: 7247407
Gerrit-PatchSet: 1
Gerrit-Owner: 王忠齐 <wzq225...@gmail.com>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Paolo Severini <paol...@microsoft.com>
Gerrit-Attention: 王忠齐 <wzq225...@gmail.com>
Gerrit-Comment-Date: Mon, 15 Dec 2025 15:42:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages