[wasm interpreter] Direct CallRef when the wasm instance is same. [v8/v8 : main]
0 views
Skip to first unread message
Clemens Backes (Gerrit)
Dec 10, 2025, 2:37:51 PM (6 days ago) Dec 10
to 王忠齐, Paolo Severini, AyeAye, v8-re...@googlegroups.com, was...@google.com
Attention needed from Paolo Severini and 王忠齐
Clemens Backes voted and added 1 comment![]( "Open in Gerrit")
Votes added by Clemens Backes
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Clemens Backes . resolved
Rubber-stamp as this only affects the interpreter. Paolo will do an actual review.
Related details
Attention is currently required from:
- Paolo Severini
- 王忠齐
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paolo Severini (Gerrit)
Dec 15, 2025, 10:42:06 AM (22 hours ago) Dec 15
to 王忠齐, Clemens Backes, AyeAye, v8-re...@googlegroups.com, was...@google.com
Attention needed from 王忠齐
Paolo Severini voted and added 1 comment![]( "Open in Gerrit")
Votes added by Paolo Severini
| Code-Review | +1 |
1 comment
File src/wasm/interpreter/wasm-interpreter-runtime.cc
Line 1932, Patchset 1 (Latest):
if (IsWasmTrustedInstanceData(*object_implicit_arg)) {Paolo Severini . unresolved
The first `if` should be redundant.
Related details
Attention is currently required from:
- 王忠齐
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paolo Severini (Gerrit)
Dec 15, 2025, 10:42:28 AM (22 hours ago) Dec 15
to 王忠齐, Clemens Backes, AyeAye, v8-re...@googlegroups.com, was...@google.com
Attention needed from 王忠齐
Paolo Severini added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Paolo Severini . resolved
LGTM, with a comment.
Related details
Attention is currently required from:
- 王忠齐
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages