[fastapi] Use no_gc variants of Managed ptr getters [v8/v8 : main]
0 views
Skip to first unread message
Maksim Ivanov (Gerrit)
Apr 2, 2026, 9:55:55 AM (4 days ago) Apr 2
to Michael Lippautz, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Maksim Ivanov added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File src/objects/templates.cc
Line 182, Patchset 1 (Latest):
i::DisallowGarbageCollection no_gc;Maksim Ivanov . resolved
IIUC the `DisallowGarbageCollection` is a stronger guarantee and is more suitable here, since if executed on the background thread we want to disallow entering safepoints (allowing the GC to make the raw pointer invalid while we're copying from it).
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Apr 2, 2026, 9:58:26 AM (4 days ago) Apr 2
to Maksim Ivanov, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Maksim Ivanov
Michael Lippautz voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Maksim Ivanov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maksim Ivanov (Gerrit)
Apr 2, 2026, 9:59:59 AM (4 days ago) Apr 2
to Michael Lippautz, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com
Maksim Ivanov voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Apr 2, 2026, 10:25:08 AM (4 days ago) Apr 2
to Maksim Ivanov, Michael Lippautz, dmercadi...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[fastapi] Use no_gc variants of Managed ptr getters
Switch the code that reads Managed<CFunctionWithSignature> onto
the raw(no_gc) variant, to let the static analysis catch possible
misuses of the raw pointers.
The parameterless raw() getter is deprecated and will be removed in the
future.
Bug: 485286897
Change-Id: Ibfeb36c1becb1313f7b42f06b33a979e043b78c7
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Maksim Ivanov <em...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#106251}
Files:
- M src/compiler/heap-refs.cc
- M src/objects/templates.cc
Change size: S
Delta: 2 files changed, 7 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages