[regexp] Throw instead of fatal on too-big regexp. [v8/v8 : main]

0 views
Skip to first unread message

Erik Corry (Gerrit)

unread,
Dec 22, 2025, 8:43:05 AM12/22/25
to Jakob Linke, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Jakob Linke

Erik Corry voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jakob Linke
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ib06f15a32b7646ddc48f34e0ac070f21869e780d
Gerrit-Change-Number: 7277651
Gerrit-PatchSet: 2
Gerrit-Owner: Erik Corry <erik...@chromium.org>
Gerrit-Reviewer: Erik Corry <erik...@chromium.org>
Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
Gerrit-Attention: Jakob Linke <jgr...@chromium.org>
Gerrit-Comment-Date: Mon, 22 Dec 2025 13:43:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Jakob Linke (Gerrit)

unread,
Jan 8, 2026, 8:51:25 AM (21 hours ago) Jan 8
to Erik Corry, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Erik Corry

Jakob Linke voted and added 1 comment

Votes added by Jakob Linke

Code-Review+1

1 comment

File src/regexp/regexp-compiler-tonode.cc
Line 42, Patchset 4 (Latest): // subclass because all call sites already have to check for this case.
Jakob Linke . unresolved

Also here, it would be great to make this easier by using macros or similar. For example, maglev has GET_VALUE_OR_ABORT etc https://source.chromium.org/chromium/chromium/src/+/main:v8/src/maglev/maglev-graph-builder.cc;l=1984;drc=e738cdba37506e2e75d1decbb35a6fddffcd86d4.

Fine in future work.

Open in Gerrit

Related details

Attention is currently required from:
  • Erik Corry
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ib06f15a32b7646ddc48f34e0ac070f21869e780d
Gerrit-Change-Number: 7277651
Gerrit-PatchSet: 4
Gerrit-Owner: Erik Corry <erik...@chromium.org>
Gerrit-Reviewer: Erik Corry <erik...@chromium.org>
Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
Gerrit-Attention: Erik Corry <erik...@chromium.org>
Gerrit-Comment-Date: Thu, 08 Jan 2026 13:51:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages