[regexp] Throw instead of fatal on too-big regexp. [v8/v8 : main]
0 views
Skip to first unread message
Erik Corry (Gerrit)
Dec 22, 2025, 8:43:05 AM12/22/25
to Jakob Linke, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Jakob Linke
Erik Corry voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Jakob Linke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Linke (Gerrit)
Jan 8, 2026, 8:51:25 AM (21 hours ago) Jan 8
to Erik Corry, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Erik Corry
Jakob Linke voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jakob Linke
| Code-Review | +1 |
1 comment
File src/regexp/regexp-compiler-tonode.cc
Line 42, Patchset 4 (Latest):
// subclass because all call sites already have to check for this case.Jakob Linke . unresolved
Also here, it would be great to make this easier by using macros or similar. For example, maglev has GET_VALUE_OR_ABORT etc https://source.chromium.org/chromium/chromium/src/+/main:v8/src/maglev/maglev-graph-builder.cc;l=1984;drc=e738cdba37506e2e75d1decbb35a6fddffcd86d4.
Fine in future work.
Related details
Attention is currently required from:
- Erik Corry
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages