[TurboFan] Add BigInt support to %VerifyType [v8/v8 : main]
Nico Hartmann (Gerrit)
Attention is currently required from: Tobias Tebbi.
1 comment:
Patchset:
PTAL, thanks
To view, visit change 3256687. To unsubscribe, or for help writing mail filters, visit settings.
Tobias Tebbi (Gerrit)
Attention is currently required from: Nico Hartmann.
1 comment:
File src/objects/turbofan-types.tq:
Patch Set #1, Line 162:
Convert<uintptr>(Convert<float64>(0x7FFFFFFFFFFFFFFF))This conversion loses precision, so it doesn't really check the right thing.
To view, visit change 3256687. To unsubscribe, or for help writing mail filters, visit settings.
Nico Hartmann (Gerrit)
Attention is currently required from: Tobias Tebbi.
Patch set 2:-Commit-Queue
2 comments:
Patchset:
Now using new 64bit integer literals! PTAL
File src/objects/turbofan-types.tq:
Patch Set #1, Line 162:
Convert<uintptr>(Convert<float64>(0x7FFFFFFFFFFFFFFF))This conversion loses precision, so it doesn't really check the right thing.
Ack
To view, visit change 3256687. To unsubscribe, or for help writing mail filters, visit settings.
Tobias Tebbi (Gerrit)
File src/torque/implementation-visitor.cc:
Patch Set #3, Line 962:
"IntegerLiteral(" << expr->value << "ull)";Are you sure this is necessary? C++ should automatically pick a fitting type.
To view, visit change 3256687. To unsubscribe, or for help writing mail filters, visit settings.
Nico Hartmann (Gerrit)
Attention is currently required from: Tobias Tebbi.
1 comment:
File src/torque/implementation-visitor.cc:
Patch Set #3, Line 962:
"IntegerLiteral(" << expr->value << "ull)";Are you sure this is necessary? C++ should automatically pick a fitting type.
Yes, got a respective compiler error, that's why I changed it.
To view, visit change 3256687. To unsubscribe, or for help writing mail filters, visit settings.
Tobias Tebbi (Gerrit)
Attention is currently required from: Nico Hartmann.
Patch set 3:Code-Review +1
2 comments:
Patchset:
Thanks!
File src/torque/implementation-visitor.cc:
Patch Set #3, Line 962:
"IntegerLiteral(" << expr->value << "ull)";
Yes, got a respective compiler error, that's why I changed it.
Ack
To view, visit change 3256687. To unsubscribe, or for help writing mail filters, visit settings.
Nico Hartmann (Gerrit)
Attention is currently required from: Nico Hartmann.
Patch set 4:Commit-Queue +2
V8 LUCI CQ (Gerrit)
V8 LUCI CQ submitted this change.
3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: src/torque/implementation-visitor.cc
Insertions: 3, Deletions: 8.
The diff is too large to show. Please review the diff.
```
[TurboFan] Add BigInt support to %VerifyType
This CL adds handling of the BigInt types to TurbofanType to allow
verification of BigInt values in %VerifyType.
Change-Id: I1fc6dea16cbff4d22cfbb5483c5dee50fa932f75
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3256687
Reviewed-by: Tobias Tebbi <te...@chromium.org>
Commit-Queue: Nico Hartmann <nicoha...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79169}
---
M src/objects/turbofan-types.tq
1 file changed, 52 insertions(+), 5 deletions(-)