[maglev] Track elements-kind transitions precisely in loop effects [v8/v8 : main]
0 views
Skip to first unread message
Victor Gomes (Gerrit)
Jul 24, 2026, 9:02:19 AM (20 hours ago) Jul 24
to Olivier Flückiger, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Olivier Flückiger
Victor Gomes voted and added 1 comment![]( "Open in Gerrit")
Votes added by Victor Gomes
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Victor Gomes . resolved
PTAL! I am trying to preserve elements load after a peel.
Related details
Attention is currently required from:
- Olivier Flückiger
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olivier Flückiger (Gerrit)
Jul 24, 2026, 9:30:48 AM (19 hours ago) Jul 24
to Victor Gomes, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes
Olivier Flückiger voted and added 1 comment![]( "Open in Gerrit")
Votes added by Olivier Flückiger
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jul 24, 2026, 9:47:33 AM (19 hours ago) Jul 24
to Victor Gomes, Olivier Flückiger, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[maglev] Track elements-kind transitions precisely in loop effects
TransitionElementsKind(OrCheckMap) in a loop body currently sets
unstable_aspects_cleared, which drops every cached property load at
loop headers. Record it as a dedicated elements_kind_transitioned flag
instead: unstable map facts are still invalidated exactly as before,
but named-property caches survive, and [Elements] caches survive for
objects whose maps are known, fresh and therefore stable (stable maps
cannot be transition sources).
Bug: 517439598
Change-Id: Iebed23d6500a779a7d310866c90a99e0b92f4c99
Reviewed-by: Olivier Flückiger <ol...@chromium.org>
Commit-Queue: Victor Gomes <victo...@chromium.org>
Commit-Queue: Olivier Flückiger <ol...@chromium.org>
Auto-Submit: Victor Gomes <victo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#108867}
Files:
- M src/maglev/maglev-graph-builder.h
- M src/maglev/maglev-graph-printer.cc
- M src/maglev/maglev-interpreter-frame-state.h
- M src/maglev/maglev-known-node-aspects.cc
- M src/maglev/maglev-known-node-aspects.h
- M src/maglev/maglev-post-hoc-optimizations-processors.h
- A test/mjsunit/maglev/elements-transition-loop-invariant.js
Change size: M
Delta: 7 files changed, 174 insertions(+), 29 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Olivier Flückiger
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages