[compiler][arm64] Fix Cpy and Set scheduling [v8/v8 : main]

[Sam Parker-Haynes (Gerrit)]

Attention needed from Matthias Liedtke and Sam Parker-Haynes

Sam Parker-Haynes voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

• Matthias Liedtke
• Sam Parker-Haynes

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I530c43fd00f012b7384f08577941dec1c6300fb5

Gerrit-Change-Number: 7415269

Gerrit-PatchSet: 1

Gerrit-Owner: Sam Parker-Haynes <sam.p...@arm.com>

Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>

Gerrit-Reviewer: Sam Parker-Haynes <sam.p...@arm.com>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Matthias Liedtke <mlie...@chromium.org>

Gerrit-Attention: Sam Parker-Haynes <sam.p...@arm.com>

Gerrit-Comment-Date: Fri, 09 Jan 2026 11:24:28 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Sam Parker-Haynes (Gerrit)]

Attention needed from Matthias Liedtke

Sam Parker-Haynes added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Sam Parker-Haynes . unresolved

Hi Matthias, the mac build has failed, but it looks like infrastructure issues?

Open in Gerrit

Related details

Attention is currently required from:

• Matthias Liedtke

Submit Requirements:

• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I530c43fd00f012b7384f08577941dec1c6300fb5

Gerrit-Change-Number: 7415269

Gerrit-PatchSet: 1

Gerrit-Owner: Sam Parker-Haynes <sam.p...@arm.com>

Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>

Gerrit-Reviewer: Sam Parker-Haynes <sam.p...@arm.com>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Matthias Liedtke <mlie...@chromium.org>

Gerrit-Comment-Date: Fri, 09 Jan 2026 11:25:16 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Matthias Liedtke (Gerrit)]

Attention needed from Sam Parker-Haynes

Matthias Liedtke voted and added 2 comments

Votes added by Matthias Liedtke

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Sam Parker-Haynes . resolved

Hi Matthias, the mac build has failed, but it looks like infrastructure issues?

Matthias Liedtke

It seems like it recovered already. 😊

File-level comment, Patchset 1 (Latest):

Matthias Liedtke . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:

• Sam Parker-Haynes

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I530c43fd00f012b7384f08577941dec1c6300fb5

Gerrit-Change-Number: 7415269

Gerrit-PatchSet: 1

Gerrit-Owner: Sam Parker-Haynes <sam.p...@arm.com>

Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>

Gerrit-Reviewer: Sam Parker-Haynes <sam.p...@arm.com>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Sam Parker-Haynes <sam.p...@arm.com>

Gerrit-Comment-Date: Fri, 09 Jan 2026 13:16:49 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Sam Parker-Haynes <sam.p...@arm.com>

[Sam Parker-Haynes (Gerrit)]

Sam Parker-Haynes voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I530c43fd00f012b7384f08577941dec1c6300fb5

Gerrit-Change-Number: 7415269

Gerrit-PatchSet: 1

Gerrit-Owner: Sam Parker-Haynes <sam.p...@arm.com>

Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>

Gerrit-Reviewer: Sam Parker-Haynes <sam.p...@arm.com>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Comment-Date: Fri, 09 Jan 2026 13:29:30 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[V8 LUCI CQ (Gerrit)]

V8 LUCI CQ submitted the change

Change information

Commit message:

[compiler][arm64] Fix Cpy and Set scheduling

Both these operations write to memory, so we need to set the side
effect flags to prevent the scheduler from reordering them
incorrectly.

Bug: 474141354

Change-Id: I530c43fd00f012b7384f08577941dec1c6300fb5

Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7415269

Reviewed-by: Matthias Liedtke <mlie...@chromium.org>

Commit-Queue: Sam Parker-Haynes <sam.p...@arm.com>

Cr-Commit-Position: refs/heads/main@{#104596}

Files:

• M src/compiler/backend/arm64/instruction-scheduler-arm64.cc
• A test/mjsunit/wasm/regress-474141354.js

Change size: M

Delta: 2 files changed, 52 insertions(+), 2 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Matthias Liedtke

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I530c43fd00f012b7384f08577941dec1c6300fb5

Gerrit-Change-Number: 7415269

Gerrit-PatchSet: 2

Gerrit-Owner: Sam Parker-Haynes <sam.p...@arm.com>

Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>

Gerrit-Reviewer: Sam Parker-Haynes <sam.p...@arm.com>

Gerrit-Reviewer: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>