[memory_reducer] Add SimpleMemoryReducer implementation [v8/v8 : main]

0 views
Skip to first unread message

Thiabaud Engelbrecht (Gerrit)

unread,
Oct 24, 2025, 9:51:34 AM (7 days ago) Oct 24
to Etienne Pierre-Doray, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Etienne Pierre-Doray

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ib36d48d6e1773cd21a19cb1abb89e887c8282c0a
Gerrit-Change-Number: 7079990
Gerrit-PatchSet: 3
Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Comment-Date: Fri, 24 Oct 2025 13:51:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Etienne Pierre-Doray (Gerrit)

unread,
Oct 27, 2025, 12:40:06 PM (4 days ago) Oct 27
to Thiabaud Engelbrecht, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Thiabaud Engelbrecht

Etienne Pierre-Doray added 1 comment

File src/heap/memory-reducer.cc
Line 318, Patchset 5 (Latest): heap->main_thread_local_heap(), heap->GCFlagsForIncrementalMarking(),
Etienne Pierre-Doray . unresolved

Similar to original MemoryReducer, we need to force GCFlag::kReduceMemoryFootprint here.

Open in Gerrit

Related details

Attention is currently required from:
  • Thiabaud Engelbrecht
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib36d48d6e1773cd21a19cb1abb89e887c8282c0a
    Gerrit-Change-Number: 7079990
    Gerrit-PatchSet: 5
    Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-CC: Hannes Payer <hpa...@chromium.org>
    Gerrit-Attention: Thiabaud Engelbrecht <thia...@google.com>
    Gerrit-Comment-Date: Mon, 27 Oct 2025 16:40:02 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    open
    diffy

    Thiabaud Engelbrecht (Gerrit)

    unread,
    Oct 27, 2025, 4:30:30 PM (4 days ago) Oct 27
    to Etienne Pierre-Doray, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
    Attention needed from Etienne Pierre-Doray

    Thiabaud Engelbrecht added 1 comment

    File src/heap/memory-reducer.cc
    Line 318, Patchset 5: heap->main_thread_local_heap(), heap->GCFlagsForIncrementalMarking(),
    Etienne Pierre-Doray . resolved

    Similar to original MemoryReducer, we need to force GCFlag::kReduceMemoryFootprint here.

    Thiabaud Engelbrecht

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Etienne Pierre-Doray
    Submit Requirements:
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: v8/v8
      Gerrit-Branch: main
      Gerrit-Change-Id: Ib36d48d6e1773cd21a19cb1abb89e887c8282c0a
      Gerrit-Change-Number: 7079990
      Gerrit-PatchSet: 7
      Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>
      Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-CC: Hannes Payer <hpa...@chromium.org>
      Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Comment-Date: Mon, 27 Oct 2025 20:30:27 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Etienne Pierre-Doray <etie...@chromium.org>
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages