[regexp] Refactor src/regexp into v8::internal::regexp namespace [v8/v8 : main]

0 views

Skip to first unread message

Patrick Thier (Gerrit)

unread,

11:48 AM (8 hours ago) 11:48 AM

to Jakob Linke, V8 LUCI CQ, Fadi Meawad, Hannes Payer, alph+...@chromium.org, cbruni...@chromium.org, devtools-...@chromium.org, dmercadi...@chromium.org, jgrube...@chromium.org, lpy+v8...@chromium.org, marja...@chromium.org, mlippau...@chromium.org, pthier...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org

Attention needed from Jakob Linke

Patrick Thier added 3 comments

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Patrick Thier . resolved

PTAL
I know the size of the CL is intimidating, but the vast majority of changes is just removing the `RegExp` prefix. So most files should be trivial to review.

File src/regexp/experimental/experimental-interpreter.cc

Line 1496, Patchset 6 (Latest): struct LookaroundInfo {

Patrick Thier . unresolved

Renamed to not shadow class name.

File src/regexp/regexp-ast.h

Line 542, Patchset 6 (Latest):

  static TextElement FromAtom(Atom* atom);
  static TextElement FromClassRanges(ClassRanges* class_ranges);

Patrick Thier . unresolved

Renamed to not shadow class names.

Open in Gerrit

Related details

Attention is currently required from:

Jakob Linke

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages