[maglev] Try to untag phis to Int32 instead of Float64 for int HeapNums [v8/v8 : main]
0 views
Skip to first unread message
Darius Mercadier (Gerrit)
Sep 4, 2025, 6:35:50 AM (3 days ago) Sep 4
to Victor Gomes, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes
Darius Mercadier voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darius Mercadier
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Gomes (Gerrit)
Sep 4, 2025, 7:41:15 AM (3 days ago) Sep 4
to Darius Mercadier, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Darius Mercadier
Victor Gomes voted![]( "Open in Gerrit")
Attention is currently required from:
- Darius Mercadier
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Sep 4, 2025, 8:04:08 AM (3 days ago) Sep 4
to Darius Mercadier, Victor Gomes, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[maglev] Try to untag phis to Int32 instead of Float64 for int HeapNums
When a 32-bit integer doesn't fit in a Smi, V8 will box it to a
HeapNumber, and Maglev will then assume that it's a double.
For instance,
function foo() {
let i = 1732584193; // doesn't fit in a Smi
for (; i == 1732584193;) {
i = i ^ 1;
}
return i;
}
%PrepareFunctionForOptimization(foo);
print(foo());
print(foo());
%OptimizeMaglevOnNextCall(foo);
print(foo());
Before this CL, `i` would have been untagged to Float64, and it will
now be untagged to Int32 instead.
Bug: 431933185
Change-Id: I7cbcb30a7336f464e5dc23c8e6652ecfffede260
Reviewed-by: Victor Gomes <victo...@chromium.org>
Auto-Submit: Darius Mercadier <dmerc...@chromium.org>
Commit-Queue: Victor Gomes <victo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#102243}
Files:
- M src/maglev/maglev-phi-representation-selector.cc
Change size: S
Delta: 1 file changed, 23 insertions(+), 8 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Victor Gomes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages