Fix build on gcc [v8/v8 : main]
Jakob Linke (Gerrit)
Jakob Linke voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
- Abdirahim
- Nico Hartmann
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Hartmann (Gerrit)
Nico Hartmann added 1 comment![]( "Open in Gerrit")
struct arguments_base {Using a base class to solve this caused some issues on our side that's why I went away from that. I would prefer if we could find a different solution.
If the problem is just from the nested struct, we can easily just change `struct builtin` to `namespace builtin`, which I was considering to do anyway. Can you please check if this would solve the issue?
Related details
- Abdirahim
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Abdirahim (Gerrit)
Abdirahim added 1 comment![]( "Open in Gerrit")
struct arguments_base {Using a base class to solve this caused some issues on our side that's why I went away from that. I would prefer if we could find a different solution.
If the problem is just from the nested struct, we can easily just change `struct builtin` to `namespace builtin`, which I was considering to do anyway. Can you please check if this would solve the issue?
Hello Nico, I'm rab a build to see if changing builtin to a namespace resolves the issue:
```diff
diff --git a/src/compiler/turboshaft/builtin-call-descriptors.h b/src/compiler/turboshaft/builtin-call-descriptors.h
index 1a6e66969cc..82c4eab43aa 100644
--- a/src/compiler/turboshaft/builtin-call-descriptors.h
+++ b/src/compiler/turboshaft/builtin-call-descriptors.h
@@ -55,7 +55,7 @@ struct IndexTag<0> {
// TODO(nicohartmann): Consider a different name, but currently everything that
// is not lengthy is already used in so many other places that constant name
// collisions are unavoidable.
-struct builtin {
+namespace builtin {
// TODO(nicohartmann@): Unfortunately, we cannot define builtins with
// void/never return types properly (e.g. in Torque), but they typically have
// a JSAny dummy return type. Use Void/Never sentinels to express that in
```
Unfortunately that also failed in the same way as before.
GCC seems to think that the meaning of `index_counter` and `make_args_type_list_n` is being changed in the ARGS macro.
If its of use I can work on developing a simple example showing the issue in
compiler explorer.
Related details
- Nico Hartmann
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |