[wasm][shared] Add Wasm objects to JSReceiver::class_name [v8/v8 : main]
0 views
Skip to first unread message
Manos Koukoutos (Gerrit)
11:43 AM (11 hours ago) 11:43 AM
to Matthias Liedtke, v8-re...@googlegroups.com
Attention needed from Matthias Liedtke
Manos Koukoutos voted and added 1 comment![]( "Open in Gerrit")
Votes added by Manos Koukoutos
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Matthias Liedtke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matthias Liedtke (Gerrit)
11:52 AM (11 hours ago) 11:52 AM
to Manos Koukoutos, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Manos Koukoutos
Matthias Liedtke added 1 comment![]( "Open in Gerrit")
File test/mjsunit/regress/wasm/regress-493088266.js
Line 23, Patchset 1 (Latest):
} catch (e) {
print("Caught: " + e);
}Matthias Liedtke . unresolved
This should be an `assertThrows` that wraps the part that we care about, ideally asserting at least the error type if not parts of the error message.
Related details
Attention is currently required from:
- Manos Koukoutos
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Manos Koukoutos (Gerrit)
12:49 PM (10 hours ago) 12:49 PM
to V8 LUCI CQ, Matthias Liedtke, v8-re...@googlegroups.com
Attention needed from Matthias Liedtke
Manos Koukoutos voted and added 1 comment![]( "Open in Gerrit")
Votes added by Manos Koukoutos
| Auto-Submit | +1 |
1 comment
File test/mjsunit/regress/wasm/regress-493088266.js
This should be an `assertThrows` that wraps the part that we care about, ideally asserting at least the error type if not parts of the error message.
Attention is currently required from:
- Matthias Liedtke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matthias Liedtke (Gerrit)
12:52 PM (10 hours ago) 12:52 PM
to Manos Koukoutos, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Manos Koukoutos
Matthias Liedtke voted and added 1 comment![]( "Open in Gerrit")
Votes added by Matthias Liedtke
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Manos Koukoutos
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
2:29 PM (8 hours ago) 2:29 PM
to Manos Koukoutos, Matthias Liedtke, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[wasm][shared] Add Wasm objects to JSReceiver::class_name
Bug: 42204563, 493088266
Change-Id: I1151352fbd8421873a96f20d472c533b06018825
Auto-Submit: Manos Koukoutos <mano...@chromium.org>
Reviewed-by: Matthias Liedtke <mlie...@chromium.org>
Commit-Queue: Matthias Liedtke <mlie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105832}
Files:
- M src/objects/js-objects.cc
- A test/mjsunit/regress/wasm/regress-493088266.js
Change size: S
Delta: 2 files changed, 27 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Matthias Liedtke
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages