[wasm][shared] Add Wasm objects to JSReceiver::class_name [v8/v8 : main]

0 views
Skip to first unread message

Manos Koukoutos (Gerrit)

unread,
11:43 AM (11 hours ago) 11:43 AM
to Matthias Liedtke, v8-re...@googlegroups.com
Attention needed from Matthias Liedtke

Manos Koukoutos voted and added 1 comment

Votes added by Manos Koukoutos

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Manos Koukoutos . resolved

PTAL.

Open in Gerrit

Related details

Attention is currently required from:
  • Matthias Liedtke
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I1151352fbd8421873a96f20d472c533b06018825
Gerrit-Change-Number: 7670458
Gerrit-PatchSet: 1
Gerrit-Owner: Manos Koukoutos <mano...@chromium.org>
Gerrit-Reviewer: Manos Koukoutos <mano...@chromium.org>
Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
Gerrit-Attention: Matthias Liedtke <mlie...@chromium.org>
Gerrit-Comment-Date: Mon, 16 Mar 2026 15:43:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Matthias Liedtke (Gerrit)

unread,
11:52 AM (11 hours ago) 11:52 AM
to Manos Koukoutos, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Manos Koukoutos

Matthias Liedtke added 1 comment

File test/mjsunit/regress/wasm/regress-493088266.js
Line 23, Patchset 1 (Latest): } catch (e) {
print("Caught: " + e);
}
Matthias Liedtke . unresolved

This should be an `assertThrows` that wraps the part that we care about, ideally asserting at least the error type if not parts of the error message.

Open in Gerrit

Related details

Attention is currently required from:
  • Manos Koukoutos
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: I1151352fbd8421873a96f20d472c533b06018825
    Gerrit-Change-Number: 7670458
    Gerrit-PatchSet: 1
    Gerrit-Owner: Manos Koukoutos <mano...@chromium.org>
    Gerrit-Reviewer: Manos Koukoutos <mano...@chromium.org>
    Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
    Gerrit-Attention: Manos Koukoutos <mano...@chromium.org>
    Gerrit-Comment-Date: Mon, 16 Mar 2026 15:52:09 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Manos Koukoutos (Gerrit)

    unread,
    12:49 PM (10 hours ago) 12:49 PM
    to V8 LUCI CQ, Matthias Liedtke, v8-re...@googlegroups.com
    Attention needed from Matthias Liedtke

    Manos Koukoutos voted and added 1 comment

    Votes added by Manos Koukoutos

    Auto-Submit+1

    1 comment

    File test/mjsunit/regress/wasm/regress-493088266.js
    Line 23, Patchset 1: } catch (e) {
    print("Caught: " + e);
    }
    Matthias Liedtke . resolved

    This should be an `assertThrows` that wraps the part that we care about, ideally asserting at least the error type if not parts of the error message.

    Manos Koukoutos

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Matthias Liedtke
    Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: v8/v8
      Gerrit-Branch: main
      Gerrit-Change-Id: I1151352fbd8421873a96f20d472c533b06018825
      Gerrit-Change-Number: 7670458
      Gerrit-PatchSet: 2
      Gerrit-Owner: Manos Koukoutos <mano...@chromium.org>
      Gerrit-Reviewer: Manos Koukoutos <mano...@chromium.org>
      Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
      Gerrit-Attention: Matthias Liedtke <mlie...@chromium.org>
      Gerrit-Comment-Date: Mon, 16 Mar 2026 16:49:38 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Matthias Liedtke <mlie...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Matthias Liedtke (Gerrit)

      unread,
      12:52 PM (10 hours ago) 12:52 PM
      to Manos Koukoutos, V8 LUCI CQ, v8-re...@googlegroups.com
      Attention needed from Manos Koukoutos

      Matthias Liedtke voted and added 1 comment

      Votes added by Matthias Liedtke

      Code-Review+1
      Commit-Queue+2

      1 comment

      Patchset-level comments
      File-level comment, Patchset 2 (Latest):
      Matthias Liedtke . resolved

      LGTM

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Manos Koukoutos
      Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: v8/v8
      Gerrit-Branch: main
      Gerrit-Change-Id: I1151352fbd8421873a96f20d472c533b06018825
      Gerrit-Change-Number: 7670458
      Gerrit-PatchSet: 2
      Gerrit-Owner: Manos Koukoutos <mano...@chromium.org>
      Gerrit-Reviewer: Manos Koukoutos <mano...@chromium.org>
      Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
      Gerrit-Attention: Manos Koukoutos <mano...@chromium.org>
      Gerrit-Comment-Date: Mon, 16 Mar 2026 16:52:07 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      V8 LUCI CQ (Gerrit)

      unread,
      2:29 PM (8 hours ago) 2:29 PM
      to Manos Koukoutos, Matthias Liedtke, v8-re...@googlegroups.com

      V8 LUCI CQ submitted the change

      Change information

      Commit message:
      [wasm][shared] Add Wasm objects to JSReceiver::class_name
      Bug: 42204563, 493088266
      Change-Id: I1151352fbd8421873a96f20d472c533b06018825
      Auto-Submit: Manos Koukoutos <mano...@chromium.org>
      Reviewed-by: Matthias Liedtke <mlie...@chromium.org>
      Commit-Queue: Matthias Liedtke <mlie...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#105832}
      Files:
      • M src/objects/js-objects.cc
      • A test/mjsunit/regress/wasm/regress-493088266.js
      Change size: S
      Delta: 2 files changed, 27 insertions(+), 0 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Matthias Liedtke
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: v8/v8
      Gerrit-Branch: main
      Gerrit-Change-Id: I1151352fbd8421873a96f20d472c533b06018825
      Gerrit-Change-Number: 7670458
      Gerrit-PatchSet: 3
      Gerrit-Owner: Manos Koukoutos <mano...@chromium.org>
      Gerrit-Reviewer: Manos Koukoutos <mano...@chromium.org>
      Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages