[snapshot] Allow larger code alignments [v8/v8 : main]
0 views
Skip to first unread message
Kasper Lund (Gerrit)
Nov 18, 2025, 7:57:54 AM (yesterday) Nov 18
to Jakob Linke, V8 LUCI CQ, jgrube...@chromium.org, v8-re...@googlegroups.com
Attention needed from Jakob Linke
Kasper Lund added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Kasper Lund . resolved
I might be missing something here, but we'd like more flexibility for code-related alignment on RISC-V and some of these static asserts got in the way. Let me know what you think!
Related details
Attention is currently required from:
- Jakob Linke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Linke (Gerrit)
Nov 18, 2025, 8:23:25 AM (yesterday) Nov 18
to Kasper Lund, V8 LUCI CQ, jgrube...@chromium.org, v8-re...@googlegroups.com
Attention needed from Kasper Lund
Jakob Linke voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jakob Linke
| Code-Review | +1 |
1 comment
Patchset-level comments
Kasper Lund . resolved
I might be missing something here, but we'd like more flexibility for code-related alignment on RISC-V and some of these static asserts got in the way. Let me know what you think!
Jakob Linke
Makes sense for today's kCodeAlignment settings. The complexity was there because V8 used to have kCodeAlignmentBits 5 which we later had to bump to 6 for various use cases. The comment in globals.h seems sufficient nowadays.
Related details
Attention is currently required from:
- Kasper Lund
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kasper Lund (Gerrit)
Nov 18, 2025, 8:33:27 AM (yesterday) Nov 18
to Jakob Linke, V8 LUCI CQ, jgrube...@chromium.org, v8-re...@googlegroups.com
Kasper Lund voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Nov 18, 2025, 8:35:19 AM (24 hours ago) Nov 18
to Kasper Lund, Jakob Linke, jgrube...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[snapshot] Allow larger code alignments
Change-Id: Ic3554c7928ffa4773b67744514eaff698569a422
Reviewed-by: Jakob Linke <jgr...@chromium.org>
Commit-Queue: Kasper Lund <kas...@rivosinc.com>
Cr-Commit-Position: refs/heads/main@{#103789}
Files:
- M src/snapshot/embedded/platform-embedded-file-writer-aix.cc
- M src/snapshot/embedded/platform-embedded-file-writer-generic.cc
- M src/snapshot/embedded/platform-embedded-file-writer-mac.cc
- M src/snapshot/embedded/platform-embedded-file-writer-win.cc
Change size: M
Delta: 4 files changed, 5 insertions(+), 49 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jakob Linke
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages