[wasm] Guard against kNoBuiltinId in wasm stub disassembly [v8/v8 : main]

0 views
Skip to first unread message

Tejas Vasisht (Gerrit)

unread,
2:40 PM (7 hours ago) 2:40 PM
to Camillo Bruni, Paolo Severini, v8-re...@googlegroups.com
Attention needed from Camillo Bruni and Paolo Severini

Tejas Vasisht added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Tejas Vasisht . resolved

cbruni@, paolosev@ PTAL 😊

Open in Gerrit

Related details

Attention is currently required from:
  • Camillo Bruni
  • Paolo Severini
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I458405f7081d660033779f1cb8bdd29c47b6601c
Gerrit-Change-Number: 8025488
Gerrit-PatchSet: 2
Gerrit-Owner: Tejas Vasisht <tejasv...@microsoft.com>
Gerrit-Reviewer: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Paolo Severini <paol...@microsoft.com>
Gerrit-Attention: Paolo Severini <paol...@microsoft.com>
Gerrit-Attention: Camillo Bruni <cbr...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Jul 2026 18:40:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Paolo Severini (Gerrit)

unread,
2:49 PM (7 hours ago) 2:49 PM
to Tejas Vasisht, Camillo Bruni, v8-re...@googlegroups.com
Attention needed from Camillo Bruni and Tejas Vasisht

Paolo Severini added 1 comment

File src/diagnostics/disassembler.cc
Line 290, Patchset 2 (Parent):#endif // V8_ENABLE_WEBASSEMBLY
} else {
out << " ;; " << RelocInfo::RelocModeName(rmode);
}
Paolo Severini . unresolved

Are these lines gone?

Open in Gerrit

Related details

Attention is currently required from:
  • Camillo Bruni
  • Tejas Vasisht
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: I458405f7081d660033779f1cb8bdd29c47b6601c
    Gerrit-Change-Number: 8025488
    Gerrit-PatchSet: 2
    Gerrit-Owner: Tejas Vasisht <tejasv...@microsoft.com>
    Gerrit-Reviewer: Camillo Bruni <cbr...@chromium.org>
    Gerrit-Reviewer: Paolo Severini <paol...@microsoft.com>
    Gerrit-Attention: Tejas Vasisht <tejasv...@microsoft.com>
    Gerrit-Attention: Camillo Bruni <cbr...@chromium.org>
    Gerrit-Comment-Date: Wed, 01 Jul 2026 18:49:07 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages