[wasm][jspi] Count inlined frames for async stack traces [v8/v8 : main]
0 views
Skip to first unread message
Thibaud Michaud (Gerrit)
8:20 AM (14 hours ago) 8:20 AM
to Jakob Kummerow, v8-re...@googlegroups.com
Attention needed from Jakob Kummerow
Thibaud Michaud added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Jakob Kummerow
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Kummerow (Gerrit)
9:51 AM (13 hours ago) 9:51 AM
to Thibaud Michaud, Jakob Kummerow, v8-re...@googlegroups.com
Attention needed from Thibaud Michaud
Jakob Kummerow voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Thibaud Michaud
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thibaud Michaud (Gerrit)
10:13 AM (12 hours ago) 10:13 AM
to Jakob Kummerow, v8-re...@googlegroups.com
Thibaud Michaud voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
10:55 AM (12 hours ago) 10:55 AM
to Thibaud Michaud, Jakob Kummerow, v8-re...@googlegroups.com
v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[wasm][jspi] Count inlined frames for async stack traces
A follow-up to https://crrev.com/c/8012569: count logical frames in
GetWasmFrameCount, to match debugger stack traces.
By only counting physical frames, we will erase fewer frames than we
should from the stack trace, and will potentially end up with duplicate
frames again.
R=jkum...@chromium.org
Bug: 42203654
Change-Id: I776ae2dd51c1339edeff9e781fcfa19c9e7d8d2b
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Commit-Queue: Thibaud Michaud <thib...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#108370}
Files:
- M src/runtime/runtime-wasm.cc
Change size: XS
Delta: 1 file changed, 2 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jakob Kummerow
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages