[maglev] Avoid is_osr dcheck for suspension [v8/v8 : main]
0 views
Skip to first unread message
Toon Verwaest (Gerrit)
7:59 AM (16 hours ago) 7:59 AM
to Victor Gomes, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes
Toon Verwaest voted and added 1 comment![]( "Open in Gerrit")
Votes added by Toon Verwaest
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Gomes (Gerrit)
8:05 AM (16 hours ago) 8:05 AM
to Toon Verwaest, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Toon Verwaest
Victor Gomes voted![]( "Open in Gerrit")
Attention is currently required from:
- Toon Verwaest
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Toon Verwaest (Gerrit)
10:35 AM (13 hours ago) 10:35 AM
to Victor Gomes, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes
Toon Verwaest voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Toon Verwaest (Gerrit)
11:32 AM (12 hours ago) 11:32 AM
to Victor Gomes, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes
Toon Verwaest voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Toon Verwaest (Gerrit)
11:48 AM (12 hours ago) 11:48 AM
to Victor Gomes, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes
Toon Verwaest voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
12:27 PM (11 hours ago) 12:27 PM
to Toon Verwaest, Victor Gomes, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
V8 LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: test/mjsunit/regress/regress-474417795.js
Insertions: 2, Deletions: 2.
@@ -2,9 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// Flags: --allow-natives-syntax --jit-fuzzing --fuzzing
+// Flags: --jit-fuzzing
for (let __v_6 = 0; __v_6 < 87; __v_6++) {
async function* __f_3() { }
- %PrepareFunctionForOptimization(), __f_3(), __f_3(), %OptimizeFunctionOnNextCall(), __f_3().next();
+ __f_3(), __f_3(), __f_3().next();
}
```
```
The name of the file: src/maglev/maglev-graph.cc
Insertions: 5, Deletions: 2.
@@ -99,8 +99,11 @@
// BuildBody. We don't track context in generators (yet) and around eval
// the bytecode compiler creates contexts by calling
// Runtime::kNewFunctionInfo directly.
- DCHECK(context->Is<Phi>() || context->Is<GeneratorRestoreRegister>() ||
- context->Is<RegisterInput>() || context->Is<CallRuntime>());
+ DCHECK(
+ context->Is<Phi>() || context->Is<GeneratorRestoreRegister>() ||
+ context->Is<RegisterInput>() || context->Is<CallRuntime>() ||
+ (context->Is<LoadTaggedField>() &&
+ context->Cast<LoadTaggedField>()->load_type() == LoadType::kContext));
}
return scope_infos_[context] = res;
}
```
Change information
Commit message:
[maglev] Avoid is_osr dcheck for suspension
Bug: 474417795
Change-Id: Ia56259a7546dd82a42c345f325c32381b606f36c
Reviewed-by: Victor Gomes <victo...@chromium.org>
Commit-Queue: Toon Verwaest <verw...@chromium.org>
Auto-Submit: Toon Verwaest <verw...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104609}
Files:
- M src/maglev/maglev-graph-builder.cc
- M src/maglev/maglev-graph.cc
- M src/maglev/maglev-graph.h
- A test/mjsunit/regress/regress-474417795.js
Change size: S
Delta: 4 files changed, 23 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Victor Gomes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages