Revert "[wasm interpreter] Use r0/fp0 as a Register instanding a Value" [v8/v8 : main]

[Paolo Severini (Gerrit)]

Attention needed from Daniel Lehmann and 王忠齐

Paolo Severini added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Paolo Severini . resolved

Reverting because one regression test started failing.

Open in Gerrit

Related details

Attention is currently required from:

• Daniel Lehmann
• 王忠齐

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Iaa1aef2a19801a3aa47f0ec23109a94b27f27201

Gerrit-Change-Number: 7192337

Gerrit-PatchSet: 1

Gerrit-Owner: Paolo Severini <paol...@microsoft.com>

Gerrit-Reviewer: Daniel Lehmann <dleh...@chromium.org>

Gerrit-Reviewer: 王忠齐 <wzq225...@gmail.com>

Gerrit-Attention: Daniel Lehmann <dleh...@chromium.org>

Gerrit-Attention: 王忠齐 <wzq225...@gmail.com>

Gerrit-Comment-Date: Sun, 23 Nov 2025 10:37:18 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[王忠齐 (Gerrit)]

Attention needed from Daniel Lehmann and Paolo Severini

王忠齐 added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

王忠齐 . resolved

A WriteRegister hasn't been called in r2r_SelectF, Can I provide a CL to fix this bug?

Open in Gerrit

Related details

Attention is currently required from:

• Daniel Lehmann
• Paolo Severini

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Iaa1aef2a19801a3aa47f0ec23109a94b27f27201

Gerrit-Change-Number: 7192337

Gerrit-PatchSet: 1

Gerrit-Owner: Paolo Severini <paol...@microsoft.com>

Gerrit-Reviewer: Daniel Lehmann <dleh...@chromium.org>

Gerrit-Reviewer: Paolo Severini <paol...@microsoft.com>

Gerrit-Reviewer: 王忠齐 <wzq225...@gmail.com>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Daniel Lehmann <dleh...@chromium.org>

Gerrit-Attention: Paolo Severini <paol...@microsoft.com>

Gerrit-Comment-Date: Sun, 23 Nov 2025 10:58:41 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[王忠齐 (Gerrit)]

Attention needed from Daniel Lehmann and Paolo Severini

王忠齐 added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

王忠齐 . resolved

A WriteRegister hasn't been called in r2r_SelectF, Can I provide a CL to fix this bug?

王忠齐

I just pass the test case runned by "./tools/dev/gm.py x64.release.check", how can I run all these test cases.

Open in Gerrit

Related details

Attention is currently required from:

• Daniel Lehmann
• Paolo Severini

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Iaa1aef2a19801a3aa47f0ec23109a94b27f27201

Gerrit-Change-Number: 7192337

Gerrit-PatchSet: 1

Gerrit-Owner: Paolo Severini <paol...@microsoft.com>

Gerrit-Reviewer: Daniel Lehmann <dleh...@chromium.org>

Gerrit-Reviewer: Paolo Severini <paol...@microsoft.com>

Gerrit-Reviewer: 王忠齐 <wzq225...@gmail.com>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Daniel Lehmann <dleh...@chromium.org>

Gerrit-Attention: Paolo Severini <paol...@microsoft.com>

Gerrit-Comment-Date: Sun, 23 Nov 2025 11:07:09 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: 王忠齐 <wzq225...@gmail.com>

[王忠齐 (Gerrit)]

Attention needed from Daniel Lehmann and Paolo Severini

王忠齐 added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

王忠齐 . resolved

Sorry to introduce a issue, I fix this bug at https://chromium-review.googlesource.com/c/v8/v8/+/7195800.

Open in Gerrit

Related details

Attention is currently required from:

• Daniel Lehmann
• Paolo Severini

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Iaa1aef2a19801a3aa47f0ec23109a94b27f27201

Gerrit-Change-Number: 7192337

Gerrit-PatchSet: 1

Gerrit-Owner: Paolo Severini <paol...@microsoft.com>

Gerrit-Reviewer: Daniel Lehmann <dleh...@chromium.org>

Gerrit-Reviewer: Paolo Severini <paol...@microsoft.com>

Gerrit-Reviewer: 王忠齐 <wzq225...@gmail.com>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Daniel Lehmann <dleh...@chromium.org>

Gerrit-Attention: Paolo Severini <paol...@microsoft.com>

Gerrit-Comment-Date: Sun, 23 Nov 2025 11:58:25 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Emmanuel Romero Ruiz (Gerrit)]

Attention needed from Daniel Lehmann, Paolo Severini and 王忠齐

Emmanuel Romero Ruiz added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

王忠齐 . resolved

Sorry to introduce a issue, I fix this bug at https://chromium-review.googlesource.com/c/v8/v8/+/7195800.

Emmanuel Romero Ruiz

I suppose we could revert the change and re landed with all 3 changes, your initial commit, your fix and the tests I created in https://chromium-review.googlesource.com/c/v8/v8/+/7193576. This way we make sure there are no issues and we can include extra validation

Open in Gerrit

Related details

Attention is currently required from:

• Daniel Lehmann
• Paolo Severini
• 王忠齐

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Iaa1aef2a19801a3aa47f0ec23109a94b27f27201

Gerrit-Change-Number: 7192337

Gerrit-PatchSet: 1

Gerrit-Owner: Paolo Severini <paol...@microsoft.com>

Gerrit-Reviewer: Daniel Lehmann <dleh...@chromium.org>

Gerrit-Reviewer: Paolo Severini <paol...@microsoft.com>

Gerrit-Reviewer: 王忠齐 <wzq225...@gmail.com>

Gerrit-CC: Emmanuel Romero Ruiz <emro...@microsoft.com>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Daniel Lehmann <dleh...@chromium.org>

Gerrit-Attention: Paolo Severini <paol...@microsoft.com>

Gerrit-Attention: 王忠齐 <wzq225...@gmail.com>

Gerrit-Comment-Date: Sun, 23 Nov 2025 23:31:00 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: 王忠齐 <wzq225...@gmail.com>

[王忠齐 (Gerrit)]

Attention needed from Daniel Lehmann, Emmanuel Romero Ruiz and Paolo Severini

王忠齐 added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

王忠齐 . resolved

Sorry to introduce a issue, I fix this bug at https://chromium-review.googlesource.com/c/v8/v8/+/7195800.

Emmanuel Romero Ruiz

I suppose we could revert the change and re landed with all 3 changes, your initial commit, your fix and the tests I created in https://chromium-review.googlesource.com/c/v8/v8/+/7193576. This way we make sure there are no issues and we can include extra validation

王忠齐

There is a bug fix currently, maybe we can run all tests with this patch. If all test cases passed, add your tests and merge the bug fix maybe a better choice. Revert and then re land will block other CL for a long time. What do you think?

Open in Gerrit

Related details

Attention is currently required from:

• Daniel Lehmann
• Emmanuel Romero Ruiz
• Paolo Severini

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Iaa1aef2a19801a3aa47f0ec23109a94b27f27201

Gerrit-Change-Number: 7192337

Gerrit-PatchSet: 1

Gerrit-Owner: Paolo Severini <paol...@microsoft.com>

Gerrit-Reviewer: Daniel Lehmann <dleh...@chromium.org>

Gerrit-Reviewer: Paolo Severini <paol...@microsoft.com>

Gerrit-Reviewer: 王忠齐 <wzq225...@gmail.com>

Gerrit-CC: Emmanuel Romero Ruiz <emro...@microsoft.com>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Daniel Lehmann <dleh...@chromium.org>

Gerrit-Attention: Paolo Severini <paol...@microsoft.com>

Gerrit-Attention: Emmanuel Romero Ruiz <emro...@microsoft.com>

Gerrit-Comment-Date: Mon, 24 Nov 2025 01:53:16 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Emmanuel Romero Ruiz <emro...@microsoft.com>

Comment-In-Reply-To: 王忠齐 <wzq225...@gmail.com>

[Daniel Lehmann (Gerrit)]

Attention needed from Emmanuel Romero Ruiz and Paolo Severini

Daniel Lehmann voted and added 2 comments

Votes added by Daniel Lehmann

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Daniel Lehmann . resolved

As usual, rubber-stamping interpreter related changes (with one question).

File test/mjsunit/wasm/regress-460940948.js

File-level comment, Patchset 1 (Latest):

Daniel Lehmann . unresolved

I am missing some context, but are we planning to fix this for good and bring this test case back again? (I guess we should.)

Open in Gerrit

Related details

Attention is currently required from:

• Emmanuel Romero Ruiz
• Paolo Severini

Submit Requirements:

• Code-Owners
• Code-Review
• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Iaa1aef2a19801a3aa47f0ec23109a94b27f27201

Gerrit-Change-Number: 7192337

Gerrit-PatchSet: 1

Gerrit-Owner: Paolo Severini <paol...@microsoft.com>

Gerrit-Reviewer: Daniel Lehmann <dleh...@chromium.org>

Gerrit-Reviewer: Paolo Severini <paol...@microsoft.com>

Gerrit-Reviewer: 王忠齐 <wzq225...@gmail.com>

Gerrit-CC: Emmanuel Romero Ruiz <emro...@microsoft.com>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Paolo Severini <paol...@microsoft.com>

Gerrit-Attention: Emmanuel Romero Ruiz <emro...@microsoft.com>

Gerrit-Comment-Date: Mon, 24 Nov 2025 11:49:30 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Paolo Severini (Gerrit)]

Attention needed from Daniel Lehmann and Emmanuel Romero Ruiz

Paolo Severini added 2 comments

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Paolo Severini . resolved

Thanks for the reviews!

File test/mjsunit/wasm/regress-460940948.js

File-level comment, Patchset 1 (Latest):

Daniel Lehmann . unresolved

I am missing some context, but are we planning to fix this for good and bring this test case back again? (I guess we should.)

Paolo Severini

Yes we should certainly fix this, but since the commit caused a regression I thought it was better to revert it for the moment.

Open in Gerrit

Related details

Attention is currently required from:

• Daniel Lehmann
• Emmanuel Romero Ruiz

Submit Requirements:

• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Iaa1aef2a19801a3aa47f0ec23109a94b27f27201

Gerrit-Change-Number: 7192337

Gerrit-PatchSet: 1

Gerrit-Owner: Paolo Severini <paol...@microsoft.com>

Gerrit-Reviewer: Daniel Lehmann <dleh...@chromium.org>

Gerrit-Reviewer: Paolo Severini <paol...@microsoft.com>

Gerrit-Reviewer: 王忠齐 <wzq225...@gmail.com>

Gerrit-CC: Emmanuel Romero Ruiz <emro...@microsoft.com>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Daniel Lehmann <dleh...@chromium.org>

Gerrit-Attention: Emmanuel Romero Ruiz <emro...@microsoft.com>

Gerrit-Comment-Date: Mon, 24 Nov 2025 14:54:56 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Daniel Lehmann <dleh...@chromium.org>

[Paolo Severini (Gerrit)]

Attention needed from Daniel Lehmann and Emmanuel Romero Ruiz

Paolo Severini added 1 comment

File test/mjsunit/wasm/regress-460940948.js

File-level comment, Patchset 1 (Latest):

Daniel Lehmann . resolved

I am missing some context, but are we planning to fix this for good and bring this test case back again? (I guess we should.)

Paolo Severini

Yes we should certainly fix this, but since the commit caused a regression I thought it was better to revert it for the moment.

Paolo Severini

Done

Open in Gerrit

Related details

Attention is currently required from:

• Daniel Lehmann
• Emmanuel Romero Ruiz

Submit Requirements:

• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Iaa1aef2a19801a3aa47f0ec23109a94b27f27201

Gerrit-Change-Number: 7192337

Gerrit-PatchSet: 1

Gerrit-Owner: Paolo Severini <paol...@microsoft.com>

Gerrit-Reviewer: Daniel Lehmann <dleh...@chromium.org>

Gerrit-Reviewer: Paolo Severini <paol...@microsoft.com>

Gerrit-Reviewer: 王忠齐 <wzq225...@gmail.com>

Gerrit-CC: Emmanuel Romero Ruiz <emro...@microsoft.com>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Daniel Lehmann <dleh...@chromium.org>

Gerrit-Attention: Emmanuel Romero Ruiz <emro...@microsoft.com>

Gerrit-Comment-Date: Mon, 24 Nov 2025 14:55:20 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Daniel Lehmann <dleh...@chromium.org>

Comment-In-Reply-To: Paolo Severini <paol...@microsoft.com>

[Daniel Lehmann (Gerrit)]

Attention needed from Emmanuel Romero Ruiz and Paolo Severini

Daniel Lehmann added 1 comment

File test/mjsunit/wasm/regress-460940948.js

File-level comment, Patchset 1 (Latest):

Daniel Lehmann . resolved

I am missing some context, but are we planning to fix this for good and bring this test case back again? (I guess we should.)

Paolo Severini

Yes we should certainly fix this, but since the commit caused a regression I thought it was better to revert it for the moment.

Paolo Severini

Done

Daniel Lehmann

ACK

Open in Gerrit

Related details

Attention is currently required from:

• Emmanuel Romero Ruiz
• Paolo Severini

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Iaa1aef2a19801a3aa47f0ec23109a94b27f27201

Gerrit-Change-Number: 7192337

Gerrit-PatchSet: 1

Gerrit-Owner: Paolo Severini <paol...@microsoft.com>

Gerrit-Reviewer: Daniel Lehmann <dleh...@chromium.org>

Gerrit-Reviewer: Paolo Severini <paol...@microsoft.com>

Gerrit-Reviewer: 王忠齐 <wzq225...@gmail.com>

Gerrit-CC: Emmanuel Romero Ruiz <emro...@microsoft.com>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Paolo Severini <paol...@microsoft.com>

Gerrit-Attention: Emmanuel Romero Ruiz <emro...@microsoft.com>

Gerrit-Comment-Date: Mon, 24 Nov 2025 16:03:40 +0000

[Paolo Severini (Gerrit)]

Paolo Severini abandoned this change

Related details

Attention set is empty

Submit Requirements:

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: abandon