[test] Fix lifetime warnings in ComputeStackLimit [v8/v8 : main]
0 views
Skip to first unread message
Maksim Ivanov (Gerrit)
Apr 2, 2026, 9:13:07 PM (3 days ago) Apr 2
to Deepti Gandluri, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Deepti Gandluri
Maksim Ivanov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Maksim Ivanov
| Auto-Submit | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Maksim Ivanov . resolved
gdeepti@: Could you PTAL - asking as Europe folks are on a long weekend? This is CL#2/2 to prevent Clang roll blockers.
Related details
Attention is currently required from:
- Deepti Gandluri
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Deepti Gandluri (Gerrit)
Apr 3, 2026, 2:10:33 PM (3 days ago) Apr 3
to Maksim Ivanov, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Maksim Ivanov
Deepti Gandluri voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Maksim Ivanov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maksim Ivanov (Gerrit)
Apr 3, 2026, 3:04:51 PM (3 days ago) Apr 3
to Deepti Gandluri, V8 LUCI CQ, v8-re...@googlegroups.com
Maksim Ivanov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Maksim Ivanov
| Auto-Submit | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Apr 3, 2026, 3:07:12 PM (3 days ago) Apr 3
to Maksim Ivanov, Deepti Gandluri, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[test] Fix lifetime warnings in ComputeStackLimit
Stop doing pointer arithmetic on non-array variables, and use the
uintptr_t instead.
The old code was triggering Wlifetime-safety warnings on ToT Clang (in
addition to previously suppressed warnings on GCC):
test/cctest/test-api.cc:17441:23: error: address of stack memory is
returned later [-Werror,-Wlifetime-safety-return-stack-addr]
17441 | uint32_t* answer = &size - (size / sizeof(size));
| ^~~~
test/cctest/test-api.cc:17450:10: note: returned here
17450 | return answer;
| ^~~~~~
Bug: 482994758, 491707176
Change-Id: Ie76521013bc4bc4e9b9669c93252df39248be0ed
Commit-Queue: Maksim Ivanov <em...@chromium.org>
Reviewed-by: Deepti Gandluri <gde...@chromium.org>
Auto-Submit: Maksim Ivanov <em...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#106262}
Files:
- M test/cctest/test-api.cc
Change size: S
Delta: 1 file changed, 14 insertions(+), 25 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Deepti Gandluri
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages