[decorators] Fix auto-accessor reindexing for non-cumputed keys. [v8/v8 : main]

0 views

Skip to first unread message

Luis Pardo (Gerrit)

unread,

Nov 18, 2025, 7:45:55 PM (13 hours ago) Nov 18

to Toon Verwaest, V8 LUCI CQ, marja...@chromium.org, v8-re...@googlegroups.com

Attention needed from Toon Verwaest

Luis Pardo added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Luis Pardo . resolved

@verw...@chromium.org PTAL. Thanks!

Open in Gerrit

Related details

Attention is currently required from:

Toon Verwaest

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Toon Verwaest (Gerrit)

unread,

7:41 AM (1 hour ago) 7:41 AM

to Luis Pardo, V8 LUCI CQ, marja...@chromium.org, v8-re...@googlegroups.com

Attention needed from Luis Pardo

Toon Verwaest voted and added 1 comment

Votes added by Toon Verwaest

Code-Review	+1
Commit-Queue	+2

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Toon Verwaest . resolved

oops. Thanks

Open in Gerrit

Related details

Attention is currently required from:

Luis Pardo

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

V8 LUCI CQ (Gerrit)

unread,

7:42 AM (1 hour ago) 7:42 AM

to Luis Pardo, Toon Verwaest, marja...@chromium.org, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:

[decorators] Fix auto-accessor reindexing for non-cumputed keys.

Auto-accessor values are always visited when visiting the instance
member initializer function.

Fixed: 461485805

Bug: 42202709

Change-Id: Ib994ecf71a8b26a90bb21687393c9d15ceb49956

Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7170827

Commit-Queue: Toon Verwaest <verw...@chromium.org>

Reviewed-by: Toon Verwaest <verw...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#103815}

Files:

M src/ast/ast-function-literal-id-reindexer.cc
M test/mjsunit/decorators/regress-456538025.js
A test/mjsunit/decorators/regress-461485805.js

Change size: S

Delta: 3 files changed, 19 insertions(+), 5 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Toon Verwaest

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages