[roots] Mark ReadOnlyRoots accessors as V8_CONST [v8/v8 : main]

0 views
Skip to first unread message

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Dec 18, 2025, 10:42:20 AM12/18/25
to Leszek Swirski, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Leszek Swirski

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/jetstream-main.crossbench complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/14499918b10000

Open in Gerrit

Related details

Attention is currently required from:
  • Leszek Swirski
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ic712e6162e03a99c03780bbd6f020ddafc00f8d6
Gerrit-Change-Number: 7274611
Gerrit-PatchSet: 1
Gerrit-Owner: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Attention: Leszek Swirski <les...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Dec 2025 15:42:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Leszek Swirski (Gerrit)

unread,
Feb 3, 2026, 9:34:57 AM (19 hours ago) Feb 3
to Olivier Flückiger, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Olivier Flückiger

Leszek Swirski voted and added 1 comment

Votes added by Leszek Swirski

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Leszek Swirski . resolved

WDYT? Probably not a huge diff but might allow the compiler to hoist things out of loops or whatever?

Open in Gerrit

Related details

Attention is currently required from:
  • Olivier Flückiger
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ic712e6162e03a99c03780bbd6f020ddafc00f8d6
Gerrit-Change-Number: 7274611
Gerrit-PatchSet: 4
Gerrit-Owner: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
Gerrit-Attention: Olivier Flückiger <ol...@chromium.org>
Gerrit-Comment-Date: Tue, 03 Feb 2026 14:34:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Olivier Flückiger (Gerrit)

unread,
Feb 3, 2026, 9:40:32 AM (19 hours ago) Feb 3
to Leszek Swirski, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Leszek Swirski

Olivier Flückiger voted and added 1 comment

Votes added by Olivier Flückiger

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
Olivier Flückiger . resolved

lgtm, thanks

Open in Gerrit

Related details

Attention is currently required from:
  • Leszek Swirski
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ic712e6162e03a99c03780bbd6f020ddafc00f8d6
Gerrit-Change-Number: 7274611
Gerrit-PatchSet: 4
Gerrit-Owner: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
Gerrit-Attention: Leszek Swirski <les...@chromium.org>
Gerrit-Comment-Date: Tue, 03 Feb 2026 14:40:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Feb 3, 2026, 9:42:49 AM (19 hours ago) Feb 3
to Leszek Swirski, Olivier Flückiger, chrom...@appspot.gserviceaccount.com, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[roots] Mark ReadOnlyRoots accessors as V8_CONST

This allows for better compiler optimization of ReadOnlyRoots accessors
by marking them as constant and side-effect-free.
Change-Id: Ic712e6162e03a99c03780bbd6f020ddafc00f8d6
Reviewed-by: Olivier Flückiger <ol...@chromium.org>
Auto-Submit: Leszek Swirski <les...@chromium.org>
Commit-Queue: Olivier Flückiger <ol...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105064}
Files:
  • M src/roots/roots-inl.h
  • M src/roots/roots.h
Change size: S
Delta: 2 files changed, 26 insertions(+), 19 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Olivier Flückiger
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ic712e6162e03a99c03780bbd6f020ddafc00f8d6
Gerrit-Change-Number: 7274611
Gerrit-PatchSet: 5
Gerrit-Owner: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages