[float16array] Remove runtime flag [v8/v8 : main]
0 views
Skip to first unread message
Antoine du Hamel (Gerrit)
Dec 16, 2025, 3:30:31 PM12/16/25
to v8-flag...@chromium.org, v8-re...@googlegroups.com
Antoine du Hamel has uploaded the change for review![]( "Open in Gerrit")
Commit message
[float16array] Remove runtime flag
Float16Array is stage 4 as of ECMAScript 2025.
Change-Id: If3c03ad24c488df7d348f5f44ab9655ac3467a9e
Change diff
Change information
Files:
- M src/api/api.cc
- M src/builtins/builtins.cc
- M src/flags/flag-definitions.h
- M src/init/bootstrapper.cc
- M src/objects/elements-kind.h
- M src/objects/value-serializer.cc
- M test/cctest/test-inobject-slack-tracking.cc
- M test/cctest/test-typedarrays.cc
- M test/unittests/objects/object-unittest.cc
- M test/unittests/objects/value-serializer-unittest.cc
Change size: M
Delta: 10 files changed, 20 insertions(+), 149 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antoine du Hamel (Gerrit)
Dec 16, 2025, 5:16:05 PM12/16/25
to v8-flag...@chromium.org, v8-re...@googlegroups.com
Antoine du Hamel has uploaded the change for review![]( "Open in Gerrit")
Commit message
[regexp-escape] Remove runtime flag
Change-Id: I63554b458ab766b8693e5c1bb992c0d1e6775916
Change diff
Change information
Files:
- M src/builtins/builtins.cc
- M src/flags/flag-definitions.h
- M src/init/bootstrapper.cc
Change size: S
Delta: 3 files changed, 2 insertions(+), 14 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joyee Cheung (Gerrit)
Jan 22, 2026, 11:09:20 AM (13 days ago) Jan 22
to Antoine du Hamel, Olivier Flückiger, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Antoine du Hamel and Olivier Flückiger
Joyee Cheung added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Joyee Cheung . resolved
Antoine is thinking about enabling this for Node.js - not sure if this is stable enough to remove the flag/whether that’s a prerequisite for using them downstream. Olivier, can you take a look? Thanks!
Related details
Attention is currently required from:
- Antoine du Hamel
- Olivier Flückiger
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joyee Cheung (Gerrit)
Jan 22, 2026, 11:11:00 AM (13 days ago) Jan 22
to Antoine du Hamel, Olivier Flückiger, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Antoine du Hamel and Olivier Flückiger
Joyee Cheung added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Joyee Cheung . resolved
Antoine is thinking about enabling this for Node.js - not sure if this is stable enough to remove the flag/whether that’s a prerequisite for using them downstream. Olivier, can you take a look? Thanks!
Related details
Attention is currently required from:
- Antoine du Hamel
- Olivier Flückiger
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olivier Flückiger (Gerrit)
Jan 26, 2026, 8:49:34 AM (9 days ago) Jan 26
to Antoine du Hamel, Rezvan Mahdavi Hezaveh, Joyee Cheung, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Antoine du Hamel and Rezvan Mahdavi Hezaveh
Olivier Flückiger added 2 comments![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Antoine du Hamel
- Rezvan Mahdavi Hezaveh
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olivier Flückiger (Gerrit)
Jan 26, 2026, 8:51:00 AM (9 days ago) Jan 26
to Antoine du Hamel, Patrick Thier, Joyee Cheung, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Antoine du Hamel and Patrick Thier
Olivier Flückiger added 2 comments![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Antoine du Hamel
- Patrick Thier
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Thier (Gerrit)
Jan 26, 2026, 9:00:32 AM (9 days ago) Jan 26
to Antoine du Hamel, Olivier Flückiger, Joyee Cheung, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Antoine du Hamel
Patrick Thier added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Patrick Thier . resolved
Thanks for the contribution.
LGTM % missing bug that was already mentioned.
In addition you need to sign a CLA before we can accept your contribution: https://cla.developers.google.com/
Related details
Attention is currently required from:
- Antoine du Hamel
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antoine du Hamel (Gerrit)
Jan 26, 2026, 9:14:52 AM (9 days ago) Jan 26
to Patrick Thier, Olivier Flückiger, Joyee Cheung, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Patrick Thier
Antoine du Hamel added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Patrick Thier . unresolved
Thanks for the contribution.
LGTM % missing bug that was already mentioned.In addition you need to sign a CLA before we can accept your contribution: https://cla.developers.google.com/
Antoine du Hamel
I've already signed the CLA 5 years ago, it doesn't seem I have the option to sign it again. Regarding the missing bug, do I need to force-push a commit with the additional trailer?
Related details
Attention is currently required from:
- Patrick Thier
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Thier (Gerrit)
Jan 26, 2026, 9:17:11 AM (9 days ago) Jan 26
to Antoine du Hamel, Olivier Flückiger, Joyee Cheung, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Antoine du Hamel
Patrick Thier added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Patrick Thier . unresolved
Antoine du HamelThanks for the contribution.
LGTM % missing bug that was already mentioned.In addition you need to sign a CLA before we can accept your contribution: https://cla.developers.google.com/
I've already signed the CLA 5 years ago, it doesn't seem I have the option to sign it again. Regarding the missing bug, do I need to force-push a commit with the additional trailer?
Patrick Thier
CLA: Sorry my bad. Had a typo when checking validity. All good.
You can simply edit the commit message (There should be a link labelled "Edit" on the bottom right of the commit message box).
Related details
Attention is currently required from:
- Antoine du Hamel
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antoine du Hamel (Gerrit)
Jan 26, 2026, 9:18:04 AM (9 days ago) Jan 26
to Rezvan Mahdavi Hezaveh, Olivier Flückiger, Joyee Cheung, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Olivier Flückiger and Rezvan Mahdavi Hezaveh
Antoine du Hamel added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Olivier Flückiger
- Rezvan Mahdavi Hezaveh
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Thier (Gerrit)
Jan 26, 2026, 9:18:32 AM (9 days ago) Jan 26
to Antoine du Hamel, Olivier Flückiger, Joyee Cheung, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Antoine du Hamel
Patrick Thier added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Patrick Thier . unresolved
Antoine du HamelThanks for the contribution.
LGTM % missing bug that was already mentioned.In addition you need to sign a CLA before we can accept your contribution: https://cla.developers.google.com/
Patrick ThierI've already signed the CLA 5 years ago, it doesn't seem I have the option to sign it again. Regarding the missing bug, do I need to force-push a commit with the additional trailer?
CLA: Sorry my bad. Had a typo when checking validity. All good.
You can simply edit the commit message (There should be a link labelled "Edit" on the bottom right of the commit message box).
Patrick Thier
Seems you just found it while I typed the reply. Please put the `Bug: ` above `Change-Id:`, thanks.
Related details
Attention is currently required from:
- Antoine du Hamel
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antoine du Hamel (Gerrit)
Jan 26, 2026, 9:19:13 AM (9 days ago) Jan 26
to Patrick Thier, Olivier Flückiger, Joyee Cheung, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Olivier Flückiger and Patrick Thier
Antoine du Hamel added 2 comments![]( "Open in Gerrit")
Patchset-level comments
Antoine du HamelThanks for the contribution.
LGTM % missing bug that was already mentioned.In addition you need to sign a CLA before we can accept your contribution: https://cla.developers.google.com/
Patrick ThierI've already signed the CLA 5 years ago, it doesn't seem I have the option to sign it again. Regarding the missing bug, do I need to force-push a commit with the additional trailer?
CLA: Sorry my bad. Had a typo when checking validity. All good.
You can simply edit the commit message (There should be a link labelled "Edit" on the bottom right of the commit message box).
Attention is currently required from:
- Olivier Flückiger
- Patrick Thier
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olivier Flückiger (Gerrit)
Jan 26, 2026, 9:19:56 AM (9 days ago) Jan 26
to Antoine du Hamel, Patrick Thier, Joyee Cheung, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Antoine du Hamel and Patrick Thier
Olivier Flückiger voted and added 1 comment![]( "Open in Gerrit")
Votes added by Olivier Flückiger
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Antoine du Hamel
- Patrick Thier
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Thier (Gerrit)
Jan 26, 2026, 9:21:03 AM (9 days ago) Jan 26
to Antoine du Hamel, Olivier Flückiger, Joyee Cheung, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Antoine du Hamel
Patrick Thier voted and added 1 comment![]( "Open in Gerrit")
Votes added by Patrick Thier
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Patrick Thier . resolved
LGTM
Related details
Attention is currently required from:
- Antoine du Hamel
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Thier (Gerrit)
Jan 26, 2026, 9:22:05 AM (9 days ago) Jan 26
to Antoine du Hamel, Jakob Linke, V8 LUCI CQ, Olivier Flückiger, Joyee Cheung, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Antoine du Hamel and Jakob Linke
Patrick Thier added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Antoine du Hamel
- Jakob Linke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Linke (Gerrit)
Jan 26, 2026, 9:34:47 AM (9 days ago) Jan 26
to Antoine du Hamel, V8 LUCI CQ, Patrick Thier, Olivier Flückiger, Joyee Cheung, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Antoine du Hamel
Jakob Linke voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Antoine du Hamel
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Thier (Gerrit)
Jan 26, 2026, 9:41:04 AM (9 days ago) Jan 26
to Antoine du Hamel, Jakob Linke, V8 LUCI CQ, Olivier Flückiger, Joyee Cheung, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Antoine du Hamel
Patrick Thier voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Antoine du Hamel
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Jan 26, 2026, 10:29:07 AM (9 days ago) Jan 26
to Antoine du Hamel, Jakob Linke, Patrick Thier, Olivier Flückiger, Joyee Cheung, v8-flag...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[regexp-escape] Remove runtime flag
Bug: 353856236
Change-Id: I63554b458ab766b8693e5c1bb992c0d1e6775916
Reviewed-by: Patrick Thier <pth...@chromium.org>
Reviewed-by: Olivier Flückiger <ol...@chromium.org>
Reviewed-by: Jakob Linke <jgr...@chromium.org>
Commit-Queue: Patrick Thier <pth...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104909}
Files:
- M src/builtins/builtins.cc
- M src/flags/flag-definitions.h
- M src/init/bootstrapper.cc
Change size: S
Delta: 3 files changed, 2 insertions(+), 14 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Olivier Flückiger, +1 by Patrick Thier, +1 by Jakob Linke
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matthias Liedtke (Gerrit)
Jan 26, 2026, 1:06:28 PM (9 days ago) Jan 26
to Antoine du Hamel, V8 LUCI CQ, Jakob Linke, Patrick Thier, Olivier Flückiger, Joyee Cheung, v8-flag...@chromium.org, v8-re...@googlegroups.com
Matthias Liedtke has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rezvan Mahdavi Hezaveh (Gerrit)
Jan 26, 2026, 2:24:22 PM (9 days ago) Jan 26
to Antoine du Hamel, Olivier Flückiger, Joyee Cheung, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Antoine du Hamel and Olivier Flückiger
Rezvan Mahdavi Hezaveh voted and added 1 comment![]( "Open in Gerrit")
Votes added by Rezvan Mahdavi Hezaveh
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Antoine du Hamel
- Olivier Flückiger
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olivier Flückiger (Gerrit)
Feb 3, 2026, 9:15:40 AM (19 hours ago) Feb 3
to Antoine du Hamel, Camillo Bruni, Rezvan Mahdavi Hezaveh, Joyee Cheung, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Antoine du Hamel and Camillo Bruni
Olivier Flückiger voted and added 1 comment![]( "Open in Gerrit")
Votes added by Olivier Flückiger
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Antoine du Hamel
- Camillo Bruni
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages