[maglev] Split the checked holey double loads into a load and a conversion [v8/v8 : main]

0 views
Skip to first unread message

Victor Gomes (Gerrit)

unread,
Aug 13, 2026, 7:46:06 AM (2 days ago) Aug 13
to Patrick Thier, chrom...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Patrick Thier

Victor Gomes voted and added 1 comment

Votes added by Victor Gomes

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Victor Gomes . resolved

PTAL!

Open in Gerrit

Related details

Attention is currently required from:
  • Patrick Thier
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I3e7c27054ac53767b237f767f948672bae4adc8d
Gerrit-Change-Number: 8256831
Gerrit-PatchSet: 4
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Patrick Thier <pth...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-Attention: Patrick Thier <pth...@chromium.org>
Gerrit-Comment-Date: Thu, 13 Aug 2026 11:46:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Patrick Thier (Gerrit)

unread,
Aug 13, 2026, 10:57:28 AM (2 days ago) Aug 13
to Victor Gomes, v8-s...@luci-project-accounts.iam.gserviceaccount.com, chrom...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes

Patrick Thier voted and added 1 comment

Votes added by Patrick Thier

Code-Review+1

1 comment

Patchset-level comments
Patrick Thier . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Victor Gomes
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I3e7c27054ac53767b237f767f948672bae4adc8d
Gerrit-Change-Number: 8256831
Gerrit-PatchSet: 4
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Patrick Thier <pth...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-Attention: Victor Gomes <victo...@chromium.org>
Gerrit-Comment-Date: Thu, 13 Aug 2026 14:57:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Victor Gomes (Gerrit)

unread,
Aug 14, 2026, 5:12:01 AM (yesterday) Aug 14
to Patrick Thier, v8-s...@luci-project-accounts.iam.gserviceaccount.com, chrom...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org

Victor Gomes voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I3e7c27054ac53767b237f767f948672bae4adc8d
Gerrit-Change-Number: 8256831
Gerrit-PatchSet: 5
Gerrit-Comment-Date: Fri, 14 Aug 2026 09:11:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
Aug 14, 2026, 6:14:35 AM (yesterday) Aug 14
to Victor Gomes, Patrick Thier, chrom...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org

v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Unreviewed changes

4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
[maglev] Split the checked holey double loads into a load and a conversion

Bug: 545843233
Change-Id: I3e7c27054ac53767b237f767f948672bae4adc8d
Reviewed-by: Patrick Thier <pth...@chromium.org>
Commit-Queue: Victor Gomes <victo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#109255}
Files:
  • M src/compiler/turboshaft/turbolev-graph-builder.cc
  • M src/maglev/maglev-graph-builder.cc
  • M src/maglev/maglev-graph-optimizer.cc
  • M src/maglev/maglev-ir.cc
  • M src/maglev/maglev-ir.h
Change size: M
Delta: 5 files changed, 5 insertions(+), 143 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Patrick Thier
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I3e7c27054ac53767b237f767f948672bae4adc8d
Gerrit-Change-Number: 8256831
Gerrit-PatchSet: 6
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Patrick Thier <pth...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages